search

LoliKingdom / LoliASM

The lolis are now preparing to bytecode manipulate your game.
GNU Lesser General Public License v2.1
105 stars 23 forks source link

Loading time is increased when cleanupLaunchClassLoader feature is on #6

Closed gatoborrachon closed 3 years ago

gatoborrachon commented 3 years ago

DESCRIPTION When i use LoliASM 1.1 (with a personal modpack) it takes 553 seconds to load: [21:28:17] [Client thread/INFO] [Surge]: The game loaded in approximately 553.022 seconds.

But when i used LoliASM 2.1 it took 655: [21:16:43] [Client thread/INFO] [Surge]: The game loaded in approximately 655.957 seconds.

ADDITIONAL NOTES 1.- Well, i'm using a personal modpack, so i'm pretty sure that this may be a inter-mod incompatibility, but the possible guilty mods are my performance mods: performance

2.- Tell me if you want my modpack to test it by yourself

Rongmario commented 3 years ago

You can disable cleanupLaunchClassLoader in the config to decrease the loading time again. I'll change the config comment accordingly. I did some slight tests and it seems like remapperMemorySaver doesn't increase by a significant amount.

gatoborrachon commented 3 years ago

mmm, i set it as false and now the game doesn't even load, inside the Task Manager it says that MC uses 0% of CPU after 2 minutes.

i tried with both OpenJ9 and Hotspot: performance

performance

Rongmario commented 3 years ago

Caused by: java.lang.ClassCircularityError: zone/rong/loliasm/api/datastructures/DummyMap

I'll fix it for next minor build.

gatoborrachon commented 3 years ago

yeah sorry, i forgot to upload the log file, but as you said, it is caused by what that line says

Anyways, here is the log: latest.log