search

LoliKingdom / LoliASM

The lolis are now preparing to bytecode manipulate your game.
GNU Lesser General Public License v2.1
105 stars 23 forks source link

[1.12.2] Conflict with Immersive Engineering. ASM deletes items in the IM Tool Box. #71

Closed SonicX8000 closed 2 years ago

SonicX8000 commented 2 years ago

Minecraft: 1.12.2 Forge: 14.23.5.2860

Mods: !mixinbooter-4.2 [MixinCompat-0.8] HadEnoughItems_1.12.2-4.20.1 ImmersiveEngineering-0.12-98 loliasm-4.10

=====

"loliasm-4.10" has a bit of a conflict where it breaks the IM Tool Box. Any items put inside the Tool Box will appear to work nromally but the moment you move the tool box somewhere else in your inventory slot... it's contents are wiped clean.

asmclearingtoolbox Left: Tool Box filled with a bunch of items. Right: Moved the Tool Box 1 slot to the right, opened it... and my items are gone.

This didn't happen when using "loliasm-4.8" as no items inside the Tool Box were wiped clean. Unsure if this affects other internal storage items, such as the Bag of Holding from Extra Ultities 2, Project E's Alchemy Bag, etc.

Rongmario commented 2 years ago

latest.log and debug.log please, it could be the capability stuff we tried to optimize.

Rongmario commented 2 years ago

You can attempt to fix this by turning delayItemStackCapabilityInit off. That's what I suspect atm.

SonicX8000 commented 2 years ago

Latest & Debug Logs, had to put items inside the Tool Box and move it to another slot so it could delete them.

latest.log

debug.log

=====

Set "delayItemStackCapabilityInit" to false, and items in the Tool Box weren't deleted when I moved it to a different slot in my inventory.

Rongmario commented 2 years ago

Nothing seems to be wrong in the logs, we'll check through the stuff we did for delayItemStackCapabilityInit. Thanks for the report.

Sereath commented 2 years ago

I can confirm the same thing happening with 4.9 and Spartan Weaponry quivers.

https://gfycat.com/tediousdisguisedicelandicsheepdog

latest

debug

And just as said, with delayItemStackCapabilityInit set to false it stops happening.

https://gfycat.com/equalthirdboutu

latest

debug

Sereath commented 2 years ago

My bad, I didn't realize there was a new version (4.10), now I am away from my computer. By the way I had also tried 4.8 and even with delayItemStackCapabilityInit set to true the quiver items were fine.

SonicX8000 commented 2 years ago

My bad, I didn't realize there was a new version now (4.10), now I am away from my computer. By the way I had also tried 4.8 and even with delayItemStackCapabilityInit set to true the quiver items were fine.

Yea, with 4.8 the bug didn't occur, also delayItemStackCapabilityInit wasn't in 4.8 as that got added in 4.9+... at least when checking the config file before updating.

If you ran 4.9 / 4.10 first, that option gets added to the config. Should you downgrade to 4.8 or lower... the option will still be there but it won't do anything.

Sereath commented 2 years ago

My bad, I didn't realize there was a new version now (4.10), now I am away from my computer. By the way I had also tried 4.8 and even with delayItemStackCapabilityInit set to true the quiver items were fine.

Yea, with 4.8 the bug didn't occur, also delayItemStackCapabilityInit wasn't in 4.8 as that got added in 4.9+... at least when checking the config file before updating.

If you ran 4.9 / 4.10 first, that option gets added to the config. Should you downgrade to 4.8 or lower... the option will still be there but it won't do anything.

You are absolutely right.

SonicX8000 commented 2 years ago

The bug still occurs, using... loliasm-4.10.4 & the same mods above, minus the old version.

If you put items inside the tool box, then move it to your inventory (Not the hotbar), leave & rejoin the world... moving the tool box to your hotbar... and upon opening it... the items were gone.

latest.log debug.log

It does not occur if you move the Tool Box within your Hotbar and open it, it only bugs out if you have the toolbox in your inventory upon leaving the world.

delayItemStackCapabilityInit set to false avoids the bug.