onDemandAnimatedTextures conflict with Optifine

[xemnes]

unsure why this is happening, a LOT of textures are no longer animating, such as water and animations on blocks from most mods (it might be all of them? not sure edit: some textures are still animated, ie: teleporter effect in rftools). a lot of models in immersive engineering are broken, steel posts and other machine multiblocks look very weird https://i.imgur.com/UsK24Gy.png conveyor belts are showing missing textures https://i.imgur.com/62ceaRT.png as well as most machine blocks from thermal series https://i.imgur.com/t04KcsU.png ducts render invisible https://i.imgur.com/ON75w9T.png

edit: also noticed some other blocks dont render textures correctly anymore such as smelteryio fuel controller which is missing its face https://i.imgur.com/IZ3wwGg.png

also seems to completely break fluidlogging on all blocks with fluidlogged api.

[Rongmario]

Try restarting your game and see if most of those fix, just in case, send me your log file.

[xemnes]

sadly restarting didnt fix any of the mentioned problems

heres my log latest.log :

i wonder if its your implementation of texfix? i opted to not install it a while back as there didnt seem to be much of a difference in performance when i last used it and it did break some stuff in similar ways but i cant remember.

[Rongmario]

Seems like an OptiFine incompatibility, I'll test.

[Krutoy242]

I had same no-texture problems, but after i installed 5.2 or after i just reload game in few days, problem gone.

Through, there is still problem with animation. Yes, im running on optifine

[Rongmario]

Log file would be great as per usual

[Krutoy242]

debug.log

[xemnes]

ah yes, i just installed 5.2 and i can confirm most things have been fixed blocks are once again fluidlogged models from immersive engineering are no longer looking wacky ducts are visible no missing or broken textures

except for the animations which are still static

[HiiroSaya]

same with 5.2，portal fire and water are all freeze

[Krutoy242]

Update: When i disable this option, issue gone: B:onDemandAnimatedTextures=false

[xemnes]

ah hmm, out of curiosity, how much of an improvement on performance does this option give when enabled?

[Rongmario]

Tried replicating but animations are all fine with onDemandAnimatedTextures = true.

[xemnes]

is that with optifine? if not, then i will try narrow down which mod may be causing it

[Rongmario]

No, not with Optifine. Optifine has its own Smart Animations which does the more or less the same thing but more invasively. You can turn off LoliASM's onDemandAnimatedTextures when using Optifine's Smart Animations.

[xemnes]

ah right, ok. thanks

[Krutoy242]

Smart Animations was disabled on my side. So no animations with

Smart Animations: false
onDemandAnimatedTextures: true

[Rongmario]

Optifine invasively patches minecraft classes. I haven't had time to check if the patches I make conflict with OptiFine's, but it probably is.

[xemnes]

yeah, i had assumed this wouldnt work, so it has to be disabled in loliasm.

[Krutoy242]

Optifine invasively patches minecraft classes

Little bit offtop, but i though you just copy-past VanillaFix code to Loliasm 😅 But seems like its not, because VanillaFix haven't such problem.

[Rongmario]

OptiFine overwrite Minecraft's classes, simple-as. And no, if I just copied over VF's code, we would still have the issue such as Tinker's smelteries not having animated textures.

[xemnes]

can confirm that was an issue, i had to disable it in vanillafix to fix that issue with smelteries. optifine has always been known to be extremely mod unfriendly, and it doesnt help it is closed source also.

[Sereath]

Can confirm that this setting prevents most blocks from displaying their animations no matter what (vanilla fire, chisel blocks, thermal fluids, techguns items). And unfortunately disabling this setting isn't an option for users with AMD GPUs, the FPS hit is quite high unless they run Optifine's "Smart Animations".

[Rongmario]

Closing to make #113 the main onDemandAnimatedTextures thread.