Loloppe / BeatSaber_NoteMovementFix

Beat Saber plugin that modify base game movement.
MIT License
3 stars 1 forks source link

Question: How come disabling swap animations now disables score submission? #1

Open TheBlackParrot opened 1 year ago

TheBlackParrot commented 1 year ago

I could achieve a very similar effect pushing my JD farther out and just blocking it off with a large image via ImageFactory or something, what was the reasoning behind this? As far as I can tell, this doesn't affect hitbox calculation as it gets closer to the player, either.

Loloppe commented 1 year ago

Kinsi told me to disable it. Anyway, someone can easily recompile the plugin or get an older version if they wish to re-enable it.

TheBlackParrot commented 1 year ago

...so no reason? Just because? wtf

Loloppe commented 1 year ago

It make reading tech challenge map with a lot of those easier (but it's pretty useless for people that are used to it). It allow you to keep a lower JD and see the notes ahead, so your reaction time don't end up lowered, but this is subjective and mostly impact people that play with very close JD, like 350-450ms (can help with accuracy).

Personally I don't really care about that feature. I never used it, as I only play ranked and there's maybe only 2 or 3 ranked maps that I know where it could be useful (and they are worthless). But Kinsi is not the first person to tell me that this feature should disable score submission.

Anyway, there's a reason why this plugin is semi-private and never got released on BSMG, some of the features are borderline cheating. If ScoreSaber or BeatLeader recorded more replay data, they could easily detect people using it automatically, as this is not visual, it modify how the gameplay work directly. The only reason why pretty much nobody care about it is because it doesn't give instant free accuracy, doesn't magically make people better, can't really be abused like NJSFixer, etc. It was mostly meant as QoL for streaming.

Both the instant note swap and rotation can be achieved purely visually with no hitbox modification, which would be completely undetectable. There's just no public plugin out there that does it yet.