search

Lolzen / LolzenUI

World of Warcraft User Interface
Other
5 stars 1 forks source link

UF Restructure #49

Closed Lolzen closed 5 years ago

Lolzen commented 5 years ago

following guidelines from Rainrider's example Layout (https://github.com/Rainrider/oUF_Layout).

Initial tests seem OK, have to check if everything works feature wise. However it seems Nameplates are broken. Somewhere along must be an issue; have to find & fix before actually merging this.

Lolzen commented 5 years ago

Nameplates are now fixed. Remaining issues: Party and Raidframes are not actually showing up.

Lolzen commented 5 years ago

ToDo: rewrite bossframe spawn code following Rainrider's example layout.

Lolzen commented 5 years ago

Bossframes are fixed now. self.SetPoint() is no good and has been fixed with the correct sef.Level:SetPoint() Also following Rainrider's Bossframe implementation was having it's own issues that the boss[1-5] frames suddently were handles as petboss[1-5]; may be due the bug mentioned earlier, however i'm more comfortable using the spawnHelper anyways.

This needs some raid testing before being merged, to certify that CPU usage/mem leaks are indeed no issue anymore. Maybe some more finetuning here and there (for example, limiting unitnames to a certain length)