Lombiq / Hastlayer-SDK

Turning .NET software into FPGA hardware for faster execution and lower power usage.
https://hastlayer.com
BSD 3-Clause "New" or "Revised" License
302 stars 33 forks source link

Fix that array size passing is too eager with assignments (HAST-321) #110

Closed Piedone closed 1 year ago

Piedone commented 1 year ago

Here:

https://github.com/Lombiq/Hastlayer-SDK/blob/aed9b6f4cd2469b16ff822e0195a3e160374405a/src/Hastlayer/Hast.Transformer/Services/ConstantValuesSubstitution/ConstantValuesMarkingVisitor.cs#L216-L226

The array size from the right will be passed to the left in any case, even if on the right the array is e.g. an argument to a method call.

Let's fix this so it only passes the size if the assignment is actually an array assignment.

Jira issue