search

Lombiq / Helpful-Extensions

Orchard Core / Orchard 1.x module containing some handy extensions.
BSD 3-Clause "New" or "Revised" License
34 stars 16 forks source link

Menu Widget has stopped working (OSOE-897) #175

Open barthamark opened 3 weeks ago

barthamark commented 3 weeks ago

Menu Widget doesn't provide the UI to either pick a menu or edit a new one. Probably it stopped working after an Orchard Core upgrade.

Jira issue

sarahelsaig commented 1 week ago

The menu widget processes INavigationProvider services where the navigation name is "main" (see MainMenuNavigationProviderBase) Just like with the admin menus that come from navigation providers, these are added programmatically and can't be edited from the dashboard.

Lombiq.BaseTheme adds a provider called MainMenuNavigationProvider that uses stock OC menu convention. It looks for a content item that has a MenuItemsListPart and an alias of "main-menu" so you can edit this content item without the need for a separate UI. If you want to be fancy, you can use OrchardCore.AdminMenu to add a link pointing directly to its content item editor, OC's Blog recipe does this for example. (btw we have UI tests for this so we'd know if it was broken)

I don't think there is anything that needs to be done here. Please confirm.

barthamark commented 1 week ago

It caused confusion with the client and rightfully so. We should either rename it (e.g., NavigationWidget or MenuPlaceholderWidget) and add description to it where it says what it does exactly. Thoughts?

sarahelsaig commented 1 week ago

Renaming would be an unnecessary breaking change with not that much of an improvement in my eyes. I guess we could add further elaboration into the readme and a .WithDescription() to the widget's type definition in the migrations.

barthamark commented 1 week ago

How about renaming the Display Name? Also adding Description.

sarahelsaig commented 1 week ago

I could go for "Menu Navigation Provider Widget" as display name, if that helps.