search

Lombiq / Hosting-Build-Version-Display

Orchard Core module to display the build version (i.e. .NET assembly version or other) at a glance, showing you what's deployed.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Use GitHub-specific defaults even if BuildVersionDisplay_BuildUrl is not supplied (OSOE-543) #4

Open Piedone opened 1 year ago

Piedone commented 1 year ago

Idea by @sebastienros:

When BuildVersionDisplay_BuildUrl is not supplied, still provide a default build link for GitHub Actions builds.

Assemblies built via GitHub Actions can have the commits hash suffixed to AssemblyInformationalVersion, and the repository URL available in AssemblyMetadata("RepositoryUrl", ...). See this for Helpful Libraries (opened in ILSpy):

image

I'm not sure where these are added, specifically, because I also checked one of our deployed app's Web project, and its assembly contains neither of these attributed. Perhaps it happens during NuGet publishing?

Jira issue

Piedone commented 1 year ago

This is only needed if the given assembly is not built with one of our GitHub Actions that support BuildVersionDisplay_BuildUrl.