Test new GitHub-hosted runners (OSOE-773)

Lombiq / Open-Source-Orchard-Core-Extensions

Looking for some useful Orchard Core extensions? Here's a bundle solution of all of Lombiq's open-source Orchard Core extensions (modules and themes). Clone and try them out!

https://lombiq.com

BSD 3-Clause "New" or "Revised" License

47 stars 19 forks source link

Test new GitHub-hosted runners (OSOE-773) #671

Closed BenedekFarkas closed 9 months ago

BenedekFarkas commented 9 months ago

From the original announcement:

From now on, any Linux or Windows workflow triggered from a public repository, using GitHub’s default labels, will run on our faster, more powerful 4-vCPU runners. ... This upgrade offers increased performance, memory, and storage with 4-vCPUs, 16 GiB of memory and 150GiB storage.

Jira issue

BenedekFarkas commented 9 months ago

This is a bit surprising (as in how low):

Through the rollout, we have seen real-world improvements of around 25% for GitHub Actions workflows on these new machines without any changes required from you as a developer.

The first full test comparing these runners:

Root solution:
- buildjet-4vcpu-ubuntu-2204: 15 minutes 10 seconds
- ubuntu-22.04: 20 minute timeout
NuGet solution:
- buildjet-4vcpu-ubuntu-2204: 5 minutes 13 seconds
- ubuntu-22.04: 7 minutes 3 seconds (doesn't look it changed meaningfully compared to previous average from 7-8 builds)
NuGet solution on Windows (not fair comparison due to different core count):
- gitrunners-windows-2022-x64-8vcpu: 21 minutes 53 seconds
- windows-2022: 30 minute timeout

No need/sense to change anything now.

Piedone commented 9 months ago

Ah, awesome! It should be a lot more for us, and indeed it seems so. Roughly this is where we got this:

BuildJet is still better, but that's only Linux. GitRunners with Windows has an issue with long wait times though, sometimes even 15 minutes, which while technically doesn't count against the runtime, still makes you wait longer. Did you count that too?

BenedekFarkas commented 8 months ago

GitRunners with Windows has an issue with long wait times though, sometimes even 15 minutes, which while technically doesn't count against the runtime, still makes you wait longer. Did you count that too?

No, although I'm assuming queue times are quite varied. The concrete case I saw for this issue is that GitRunners runner started 2 and a half minutes after GitHub's own (for the same Windows build).

Piedone commented 8 months ago

OK!