search

Lombiq / Open-Source-Orchard-Core-Extensions

Looking for some useful Orchard Core extensions? Here's a bundle solution of all of Lombiq's open-source Orchard Core extensions (modules and themes). Clone and try them out!
https://lombiq.com
BSD 3-Clause "New" or "Revised" License
45 stars 18 forks source link

OSOE-835: Add test for BlockMediaThemeTemplateDirectAccessMiddleware #759

Closed AydinE closed 3 months ago

AydinE commented 3 months ago

OSOE-835 See also:

AydinE commented 3 months ago

@DemeSzabolcs This one should also be ready for review

Although I've now had to do this: https://github.com/Lombiq/Hosting-Media-Theme/compare/9c09c62a2ee5f2c6ef8e8d38012393c8d32a37b3...8c51ac10a2ac6f305cd15192fa9915a0c056159d#diff-70396c083e69274cf8b94003d816588010c018e52d68ed019c305613cddff7e8R27 Instead of navigating to the page because of the middleware See comment: https://github.com/Lombiq/Hosting-Media-Theme/pull/61/files#diff-9b916a14ce0b71c574fd1ac93dc2750c5623eb731caa7209640a82a5c94f2363R44

Because the middleware cuts off the request you are not actually redirected to a proper 404 catch page, rather the response returns a 404 and you see the chrome/browser 404 page.

github-actions[bot] commented 3 months ago

This pull request has merge conflicts. Please resolve those before requesting a review.

github-actions[bot] commented 3 months ago

This pull request has merge conflicts. Please resolve those before requesting a review.

DemeSzabolcs commented 3 months ago

FYI: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/actions/runs/9085727218/job/24969728561?pr=759#step:6:178

This can be fixed by merging from dev in UI Testing Toolbox.

github-actions[bot] commented 3 months ago

This pull request has merge conflicts. Please resolve those before requesting a review.