search

Lombiq / Orchard-Base-Theme

An Orchard Core base theme with reusable mixins, components, etc.
BSD 3-Clause "New" or "Revised" License
4 stars 3 forks source link

The main menu should populate from content items with MenuItemListPart (OSOE-623) #66

Closed sarahelsaig closed 1 year ago

sarahelsaig commented 1 year ago

For example the Blog theme uses a Menu content type that contains MenuItemListPart to create its menu.

One way to do this is adding a new INavigationProvider that either looks for a content item with "main-menu" alias, or queries for MenuItemListPart. As far as I can see there is currently no index for this content part, so if we do the latter then an additional index provider would be good too.

Jira issue

Piedone commented 1 year ago

At that point, perhaps one would rather override the given shape and display the menu directly? Or are we talking about mixing multiple providers?

sarahelsaig commented 1 year ago

I was thinking of the latter. For example Lobiq.BaseTheme.Samples you'd want to merge it with the existing main menu navigation providers.

Piedone commented 1 year ago

Sounds good.