search

Lombiq / Orchard-Vue.js

Orchard Core module that contains Vue.js and related helpers.
BSD 3-Clause "New" or "Revised" License
19 stars 12 forks source link

Vue components are not included on first build (OSOE-892) #145

Open wAsnk opened 3 months ago

wAsnk commented 3 months ago

Building a clean repo will result in missing vue components in the Lombiq.VueJs.dll and also it will do the same in projects that are using this module.

Repo steps:

  1. Delete wwwroot folder, or use a clean repository.
  2. Build the project
  3. The Lombiq.VueJs.dll is missing vue folder and the vue components.
  4. Build the project again (The wwwroot already contains all the compiled scripts for vue component)
  5. The Lombiq.VueJs.dll has all the components.

I used ILSpy to check dll resources.

The vue components should be compiled to the wwwroot folder before the assembly and the Lobiq.VueJs.dll is created.

Jira issue

Piedone commented 3 months ago

You included a solution here: https://github.com/Lombiq/Orchard-Vue.js/pull/144 Isn't that suitable long-term?

sarahelsaig commented 3 months ago

Sounds like a build order problem?

wAsnk commented 3 months ago

You included a solution here: #144 Isn't that suitable long-term?

No, that only moves the script files, but it does not solve the issue with vue components. The vue component are in the Assets/Scripts/VueComponents folder, and they require a special compilation process.

Sounds like a build order problem?

Yes

Piedone commented 3 months ago

And/or the same thing that we solved in Node.js Extensions somehow (check targets and props files), since static files built be NE weren't included in the assembly either.