search

Lomkit / laravel-rest-api

Generate Api in seconds
https://laravel-rest-api.lomkit.com/
MIT License
297 stars 18 forks source link

Optimize filters #100

Closed ThanhSonITNIC closed 5 months ago

ThanhSonITNIC commented 5 months ago

Hello @GautierDele Can you review this pull reuqest asap

GautierDele commented 5 months ago

Ok, in a few hours

GautierDele commented 5 months ago

@ThanhSonITNIC i implemented lazy validation which will make things faster and also removed the nested depth option, if this is something you consider useful, please open a new PR so we can consider this separately 😄

ThanhSonITNIC commented 5 months ago

https://github.com/Lomkit/laravel-rest-api/blob/bc82057e1f5a3e8d4096042983356390e558fb82/src/Concerns/Resource/ConfiguresRestParameters.php#L58-L60 I got error 500 Call to a member function resource() on null in line 60 when relation not defined in resource

GautierDele commented 5 months ago

Ok i'll fix it, shouldn't be hard