fix: Re-align the bitstream

Lonami / lzxd

https://crates.io/crates/lzxd

Apache License 2.0

14 stars 3 forks source link

fix: Re-align the bitstream #24

Closed ikrivosheev closed 9 months ago

ikrivosheev commented 9 months ago

I fixed the issue: https://github.com/Lonami/lzxd/issues/21

I read source code gcab and libmspack and find an interesting thin. After Uncompressed block if length is not Odd then re-align the bitstream.

Also I added:

[x] #[derive(Copy, Clone, Debug, Eq)] to DecompressError and DecodeFailed
[x] Fixed some clippy warnings

ikrivosheev commented 9 months ago

@Lonami thank you for the review! Well, bug was in re-align buffer. I removed it from Bitstream::read_raw and added it in Lzxd::decompress_next like in other implementations and it starts working!!

ikrivosheev commented 9 months ago

Now it's ready for review and merge. It's work. I checked it on my computer.