LonamiWebs / Klooni1010

libGDX game based on the original 1010!
https://lonamiwebs.github.io/klooni
GNU General Public License v3.0
233 stars 70 forks source link

Add two new themes and support for SDK-26 #33

Closed m-sameer closed 6 years ago

m-sameer commented 6 years ago

Added support for Android SDK-26. Added two new themes.

Closes #29

Lonami commented 6 years ago

Will check them tomorrow. Have you fixed the completely black/white buttons? Tried changing the pieces a bit more so they're more "unique"? Can you think of any new texture we could use that would fit?

m-sameer commented 6 years ago

I made them unique enough so that someone could easily distinguish between material and vibrant.

m-sameer commented 6 years ago

Please merge the PR now.

Lonami commented 6 years ago
DefaultMaterial Light

Do you see my point? Although they are different, you need to take a close look to notice they're different :(

Sorry for being so picky but it just isn't different or special enough in my opinion. And the combination used in the Vibrant one, even with the basic cell type (I don't like the snowflake I designed that much…) makes it look odd with such a dark empty cell: image

If you're just doing this for having 4 pull requests don't worry though, closed also count (and you already have a lot).

m-sameer commented 6 years ago

No, I was just preparing for GCI. I have exams going on right now, so I don't have time to edit this(next exam is Hindi and I am really bad at it). The exams end on 20th October, I'll edit these theme after 20.

Lonami commented 6 years ago

@mhdsmr2 Okay, good luck :)

m-sameer commented 6 years ago

I will not be able to create a great theme so I am just closing this PR. Sorry.