search

LonamiWebs / Klooni1010

libGDX game based on the original 1010!
https://lonamiwebs.github.io/klooni
GNU General Public License v3.0
233 stars 72 forks source link

Add fastlane #54

Closed Poussinou closed 6 years ago

Poussinou commented 6 years ago

This PR adds fastlane directories. Please review this PR carefully, as this is the first time I do something like this.

The about.txt file was just a way to create the "phoneScreenshots" directory, because I couldn't find a way to directly upload the images. This file doesn't exist anymore.

Lonami commented 6 years ago

There aren't a lot of changes, so it was quite straightforward to go through them :)

You added a few binary files, something I dislike, because they're not .git-friendly. As it was suggested on #53, using the F-Droid Data repo may be a better option. Other than that, it's good.

Poussinou commented 6 years ago

I believe the F-Droid core team wants to use the fastlane directories (including images) directly in the app repos, like this one, to reduce the stress on this F-Droid data repo (Already more than 48000 commits). Removing images (or avoiding adding new ones) from this repo would be very helpful to reduce his already-very-large size.

What do you think ? I know binaries files aren't welcome in a git repo, but it's the case in both your repo and the F-Droid one...

Lonami commented 6 years ago

Well, the images you posted are around 100KB in total, which isn't a lot, and I don't expect changes to them. It would probably be acceptable and purging them would possibly be fine at a later point in time (they're just screenshots) if needed. We can merge if the directory tree is correct, and I need to look up to releasing a new tag at some point.

Poussinou commented 6 years ago

I double checked the tree and that's ok for me, please have a look by yourself. I also used this repo to check everything was ok.

By the way I'm not sure tagging a new release is useful, I think F-Droid will just check this repo to find the fastlane directory and all stuff. We will see after this has been merged.

Lonami commented 6 years ago

53 hints that we need new tag. But yes, we will see. The long description in the repo you and he linked in the other issue are far longer than ours, although we don't have much to say :P

Lonami commented 6 years ago

Full description taken from Klooni's site.

Poussinou commented 6 years ago

I also translated the full description ;)

Yep we need a tag, I understand why now that I have taken a look at all this...

EDIT : Maybe you could extract hard coded strings and put them in the strings.xml file, so that I can translate them in French. The new release (with our baby Fastlane!) could be also a release where the game is translated. Should be pretty easy and not long to do, right ;) And It could be a good reason to tag a new release (because you know I totally dislike release without anything new 😄 )

Lonami commented 6 years ago

Maybe you could extract hard coded strings and put them in the strings.xml file, so that I can translate them in French

The thing is, this is a libGDX game, not a normal Android application, so I'm not sure how localization or loading strings works there. I would need to look into it. Either way, I've tried to keep the game mainly string-free (notice the high use of visual icons instead strings, although some are necessary to explain parts). It probably is be doable, and surely some people would benefit (#50).

Poussinou commented 6 years ago

Yep I noticed there wasn't a lot of strings 😛 But I cannot help you...

I'm gonna wait for this PR to be merged and a new release to be tagged before pushing other fastlane directories to other F-Droid apps.

Lonami commented 6 years ago

To make the new version more substantial we could implement more than one asset for the cells for the theme in #34. Currently there is only one possible asset for all cells, but we could implement apples, bananas, pears, and all those fruits randomly. It surely would be fun. There would be rotten fruit, too, since colours are random :P

Lonami commented 6 years ago

It'd also be interesting to have #51 which is even more job, and I'm not sure when (or if) it will be done at all. It's fine to release just the screenshots, though :)

Poussinou commented 6 years ago

Surely it could be fun, but I'm no graphic designer xD my UI aren't the best, if you see what I mean...

bb010g commented 6 years ago

If you're worried about binary file size, couldn't you use LFS?

Lonami commented 6 years ago

LFS as its name implies is for "Large File Storage". I don't think it's worth the trouble for just a few extra static KB, which can be purged if things go wrong anyway.