Issues on https://github.com/pfleidi/yaxim

LonamiWebs / Stringlate

Android application to help in strings.xml translation

https://lonamiwebs.github.io/stringlate/index

MIT License

106 stars 48 forks source link

Issues on https://github.com/pfleidi/yaxim #189

Open licaon-kter opened 6 years ago

licaon-kter commented 6 years ago

v0.13 Sorry if these are duplicates.

Issues:

servers.xml, developers.xml, prefarrays.xmland array.xml get included, maybe filter on tools:ignore="MissingTranslation"and just ignore them?
<string name="pref_dnd_when_silent">\"Do not disturb\" in silent mode</string> translated in app as "Do not disturb" blahblahblaha exported locally as "Do not disturb\" in silent mode, see missing \ before the first " ?

<string-array name="fontSizesChat">
        <item>small</item>
        <item>normal</item>
        <item>large</item>
        <item>huge</item>
    </string-array>

Exported locally ends up as:

<string-array name="fontSizesChat">
        <item>s</item>
        <item>n</item>
        <item>l</item>
        <item>huge</item>
    </string-array>

Also, I've edited them again, and on export only the second one was broken.

Lonami commented 6 years ago

servers.xml, developers.xml, prefarrays.xmland array.xml get included, maybe filter on tools:ignore="MissingTranslation"and just ignore them?

tools:ignore="MissingTranslation" is to ignore missing translation, not actually marking the strings as untranslatable from my point of view. So, adding a translation does no harm because it should just ignore those missing. I guess if a missing translation is allowed we can hide those from the user since well, they don't have to translate it.

see missing \ before the first "

That's intended, but used wrong in this case. Adding " at the start and end allows you to enter leading and trailing spaces which would otherwise be trimmed. I guess I should detect if there's its matching pair at the end or like here is only at the beginning.

<string-array name="fontSizesChat">
    <item>s</item>
    <item>n</item>
    <item>l</item>
    <item>huge</item>
</string-array>

That's very strange indeed.

Lonami commented 6 years ago

One down. Two remain.

Lonami commented 6 years ago

Two down. One remains.

Lonami commented 6 years ago

I've been trying for a while now and I can't even get the array to be recognised… Not sure what I'm doing wrong. Maybe I'm just tired.

gsantner commented 6 years ago

whats the state on this and the remaining problems?

Lonami commented 6 years ago

Like I stated I couldn't even see the array at all once exporting. Not sure what it was and I had spent a considerable amount of time on it already so I stopped :P.

It's strange, the regex would match the array name om regexr.com but not when I was debugging.