search

LonamiWebs / Stringlate

Android application to help in strings.xml translation
https://lonamiwebs.github.io/stringlate/index
MIT License
106 stars 48 forks source link

Crash on orientation Change #28

Closed reverse-unina closed 7 years ago

reverse-unina commented 7 years ago

When I perform these sequences of events, the app crashes:

  1. Click on Add New Repository
  2. Click on Discover Repositories
  3. Click on Refresh icon
  4. Orientation change
CrimsonFork commented 7 years ago

Related: while translation any unsaved data gets lost when changing the prientation.

Lonami commented 7 years ago

Copy paste reply on all the related issues. Locking the orientation is the easiest fix, implemented on commit#640706. Whenever someone complains they want to use Stringlate on landscape, or on a tablet device (which is not optimized for at all), then I might think on moving to fragments everywhere. Will be a pain if it happens.

Lonami commented 7 years ago

By getting rid of the progress dialogs, the crash can't be a problem anymore. As the commit says more work needs to be done but this is the first step.