search

LonamiWebs / Stringlate

Android application to help in strings.xml translation
https://lonamiwebs.github.io/stringlate/index
MIT License
106 stars 48 forks source link

String-arrays missing #53

Closed kelna closed 7 years ago

kelna commented 7 years ago

I translated Face Slim and I did everey string but there are still untouched strings inside string-arrays. Check this: https://github.com/indywidualny/FaceSlim/blob/master/app/src/main/res/values/strings.xml#L21-L32

Stringlate overlooks the string-array part.

Lonami commented 7 years ago

I'm aware of this lack of implementation. Thanks for posting it here for me to remember I have to fix it though!

Worst part with this problem is that I have a custom XML serializer (for people not to complain about their strings.xml structure being messed up). So I have to both think a way at how I could store this internally and how I should show it to the user, although I have a vague idea.

licaon-kter commented 7 years ago

Could you (for now) just ignore/skip them?

I see they end up in the translation (although I did not translate them), funny that one with translatable=false is there too.

Lonami commented 7 years ago

I see they end up in the translation (although I did not translate them)

Which do? The one insides the <string-array>? I can't see them.

funny that one with translatable=false is there too.

I can't find that either from Stringlate. Are you sure they're included?

licaon-kter commented 7 years ago

Just did Pedometer and I had to use Meld to merge the original and my translated, and I had these too.

Here is what Stringlate exported: https://gist.github.com/5b7e11cc4825e02aa0f56842c486eb18

Lonami commented 7 years ago

Here is what Stringlate exported: https://gist.github.com/5b7e11cc4825e02aa0f56842c486eb18

Ah, I see your point. Yes, since <string-array>'s are not supported and Stringlate ignores everything it doesn't need when applying the template (i.e. comments, unsupported tags...), then they are left there, despite being translatable or not.

Well, this wouldn't have happened if I applied no template and simply exported alphabetically (This is an experimental feature (remember, not v1.0 yet!) so please report any bugs!).

licaon-kter commented 7 years ago

There's no shortage of bugs reported... BTW, any chance of another point release so we can test the changes?

Lonami commented 7 years ago

so we can test the changes?

Which changes do you want to test? I can provide a build right now if you wish.

licaon-kter commented 7 years ago

I can build, was thinking to push a tag for F-Droid to catch to users out there. ;)

Lonami commented 7 years ago

@kelna or @licaon-kter I would like to ask, do you have any idea on how I could present the string-array's or plurals to the user?

licaon-kter commented 7 years ago

Arraytitle>string1 Arraytitle>string2

So there's some context.

Not sure if useful to show them all at once, you'll need to duplicate the translation fields needed. Eg. 7 items in array, 7 fields of original text, 7 for translation :(

Lonami commented 7 years ago

I thought exactly that, and since I need something similar for the plurals, maybe simply a TextView indicating #1, #2 for the string-array and quantity for the plurals is the best solution.

Lonami commented 7 years ago

Done on #131a55, #b660fb and #70aea6.