search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
289 stars 160 forks source link

The event system is broken (community patch only) - Vox.Populi.4.2.7 #10410

Open shaunfitz opened 1 year ago

shaunfitz commented 1 year ago

No events come through anymore, and in the advisor list the text is all garbage. Go load up any game and go look. community patch only. How come this happens. new patches break stuff, I cant believe no one picked this up.

1. Mod Version (X.Y.Z). Current Version: 4.2.7

2. DirectX Version

3. List of Other Mods

4. Describe the Issue

5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH)

8. Steps to reproduce the Issue (Optional)

9. Screenshots of the Issue (Optional)

RecursiveVision commented 1 year ago

How come this happens. new patches break stuff, I cant believe no one picked this up.

We don't test on Community Patch Only, so we rely on bug reports to fix things.

azum4roll commented 1 year ago

Events are intended for VP. You play Community Patch Only for the vanilla experience.

RecursiveVision commented 1 year ago

Are the options to enable events still present in Community Patch Only?

azum4roll commented 1 year ago

There's no event present in CP. You may use modmods that add some.

shaunfitz commented 1 year ago

The event system is in cp, you pick it in the options in the setup...Its Great. lifts the game to the next level,,,great

RecursiveVision commented 1 year ago

@azum4roll There's still leftover code and text in Community Patch Only:

            ('GAMEOPTION_EVENTS',   'TXT_KEY_GAME_OPTION_EVENTS',   'TXT_KEY_GAME_OPTION_EVENTS_HELP',  1,  1,  1),
            ('GAMEOPTION_GOOD_EVENTS_OFF',  'TXT_KEY_GAME_OPTION_EVENTS_GOOD',  'TXT_KEY_GAME_OPTION_EVENTS_GOOD_HELP', 0,  1,  1),
            ('GAMEOPTION_NEUTRAL_EVENTS_OFF',   'TXT_KEY_GAME_OPTION_EVENTS_NEUTRAL',   'TXT_KEY_GAME_OPTION_EVENTS_NEUTRAL_HELP',  0,  1,  1),
            ('GAMEOPTION_BAD_EVENTS_OFF',   'TXT_KEY_GAME_OPTION_EVENTS_BAD',   'TXT_KEY_GAME_OPTION_EVENTS_BAD_HELP',  0,  1,  1),
            ('GAMEOPTION_TRADE_EVENTS_OFF', 'TXT_KEY_GAME_OPTION_EVENTS_TRADE', 'TXT_KEY_GAME_OPTION_EVENTS_TRADE_HELP',    0,  1,  1),
            ('GAMEOPTION_CIV_SPECIFIC_EVENTS_OFF',  'TXT_KEY_GAMEOPTION_CIV_SPECIFIC_EVENTS',   'TXT_KEY_GAMEOPTION_CIV_SPECIFIC_EVENTS_HELP',  0,  1,  1),
azum4roll commented 1 year ago

They're needed for mods, in case they add events. Remember that CP is meant as a base for other overhaul mods as well.

n-core commented 1 year ago

Azum moved events from CP to VP, that's why. I think it should be reverted.

azum4roll commented 1 year ago

No it shouldn't. Make a modmod (or use one) if you want CP + events.

TechpriestEnginseer commented 11 months ago

I'm just going to move where all of the Events were moved into VP back into Community Patch. This was an unnecessary change. There is no modmod for Events in the first place.

TechpriestEnginseer commented 11 months ago

@shaunfitz you mention advisor texts, I could use some screenshots to try to understand where the "garbage" text is.