CP-ONLY Friends give gifts now

[Tesla101a]

1. Mod Version (X.Y.Z). Current Version: 4.4.2

4.4.2 COMMUNITY PATCH ONLY

2. DirectX Version

DX11

3. List of Other Mods

In Game Editor

4. Describe the Issue

I think some part of the Full Vox Populi is leaking into the Community Patch, as now in 4.4.2 when you declare a friendship the AI will randomly gift you stuff, like a lux you didn't have, or gold, out of the blue.

---

5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)

Let me know if I need this and I can provide it.

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

Let me know if I need this and I can provide it.

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH)

8. Steps to reproduce the Issue (Optional)

Just declare a friendship in a game, it happens all the time.

9. Screenshots of the Issue (Optional)

[TechpriestEnginseer]

Yes if you're struggling it'll give you gold just as you would give to the AI if you wanted to. I don't see an issue here unless you were not struggling and it is gifting you.

[Tesla101a]

Thank you! I've never seen it occur before, sounds like it not happening before was the bug and now it's behaving correctly. AI feels less selfish now!

[axatin]

Yes, that's intentional, part of additional diplomacy features. It was bugged all the time and only an empty leader screen appeared instead of the offer: https://github.com/LoneGazebo/Community-Patch-DLL/issues/10069

[axatin]

Quick question : Does it have any implications for diplomacy modifiers? does it give you a positive "Trade partner" value to your modifier like when you give gifts to your allies?

Afaik you get a positive modifier for active trade deals, but not specifically for gifts, so it's better to just trade normally and send gifts only if they ask.