search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 158 forks source link

Multiplayer CTD when offering to trade city at war #10710

Closed vaderkos closed 3 months ago

vaderkos commented 6 months ago

It's an edge case. I don't think this has high priority as this might have some implications to fix and is rather rare. I also think this might also happen in newer versions

1. Mod Version (3.10.14). Current Version: 4.5.0 Modpack 3.10.14_VP-SSEM_EU

3. List of Other Mods Only everything from 3.10.14_VP-SSEM_EU

4. Describe the Issue CTD on next turn if captured city is traded to other human player.

8. Steps to reproduce the Issue (Optional)

  1. Start war between 2 human players (A and B for simplicity, player A makes turns first).
  2. Player A offers owned city in trade deal to player B and ends turn.
  3. Player B captures offered city and only then approves deal.
  4. CTD on next turn
ilteroi commented 6 months ago

do you have a minidump?

vaderkos commented 6 months ago

@ilteroi nope, unfortunately not I can only guess. Might be the deal had null pointer to city as city was already owned by another player.

axatin commented 6 months ago

After player B accepted the deal, did a notification "The deal is no longer valid" show up?

Can you attach DiplomacyAI_TradeAgreements_Log ?

vaderkos commented 6 months ago

@ilteroi @axatin I have found some minidumps, but not sure if any of them is related exactly to described CTD. @axatin unfortunately, I can't find logs related to that game with CTD. I'll attach all logs. (It was trade between Arabia and Korea) minidumps.zip

Logs.zip

axatin commented 3 months ago

I recreated the scenario, but when I tried to accept the deal after taking the city, I got a message that the deal is no longer valid, which is the intended behavior. I assume you don't have a savegame anymore? Reopen if you have one, or if you run into the issue again.