LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
280 stars 155 forks source link

4.9 Chancery production bonus per allies don't work #11022

Closed brsoft1981 closed 1 week ago

brsoft1981 commented 1 week ago

_1. Mod Version (X.Y.Z). 4.9 Vox Pupuli with EUI

2. DirectX Version

3. List of Other Mods: None

4. Describe the Issue Chancery production bonus per allies don't work. I'm attaching a save game just before building the Chancery in my capital.


5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)

Morocco Save Game.zip

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH)

8. Steps to reproduce the Issue (Optional)

9. Screenshots of the Issue (Optional)

azum4roll commented 1 week ago

https://github.com/LoneGazebo/Community-Patch-DLL/commit/c5ca38b59549086a360daa681c7ac64252251477#diff-d5f21ce0c50b76644708883c843d34664bea5e094699d379687813a5efdddfbf

This commit removed the functionality.

Hokath commented 1 week ago

11020 For the record

ilteroi commented 1 week ago

confused ... is this a database issue now or not?

anyway city state yields should go through CvCity::SetBaseYieldRateFromCSAlliance() and CvCity::SetBaseYieldRateFromCSFriendship(). it's just that CvCity::DoTurn() is not the right place.

Hokath commented 1 week ago

Not database apparently. I've now reinstalled and I can see the table again.

axatin commented 1 week ago

@ilteroi You removed the yields given through GetYieldPerAlly() from CvCity::SetBaseYieldRateFromCSAlliance() and didn't add them anywhere else

ilteroi commented 1 week ago

it's fixed - d745770a1c7788569f4d656854ed17e78962301d