search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
280 stars 155 forks source link

readd cppcheck runner #11024

Closed JohnsterID closed 2 days ago

JohnsterID commented 1 week ago

First runs will be slow to build the cache. Place the artifact cppcheck.xml in local source directory to view in cppcheck.

Could be improved, e.g. second job doesn't run if analysis was completed in first job.

RecursiveVision commented 3 days ago

@JohnsterID Could you explain what this does?

JohnsterID commented 2 days ago

@RecursiveVision Enables cppcheck CI so people can easily load and check cppcheck static analysis. It was previously added on https://github.com/LoneGazebo/Community-Patch-DLL/pull/8652 but removed to solve cppcheck not completing.

https://www.thegeekdiary.com/cppcheck-a-static-analysis-tool-for-c-c-code/

RecursiveVision commented 2 days ago

@JohnsterID Doesn't seem to be working? Failed during this commit.

JohnsterID commented 2 days ago

@RecursiveVision The workflow was using concurrency option to stop current run if a newer run is starting so process never completes if there are heaps of commits. We need at least one run to complete before trying the concurrency option. Fixed https://github.com/LoneGazebo/Community-Patch-DLL/pull/11074.

azum4roll commented 21 hours ago

The build log is currently extremely large due to the same 36 unused function warnings being repeated for every single file. It's hard to find the actually useful warnings. Is there a setting to ignore those included files?