4.10 Carthage UA scaling is off

[randomnublet]

From 100/25 in ancient/classical to 400/100 in Medieval, where it should be 200/50 (400/100 being the Industrial Era expected value instead).

[Hokath]

As I commented in the thread: is it possible you got 2 increases in the same turn?

[randomnublet]

No, multiple new luxuries give multiple notifications: here is the notification log after I build the Great Cothon in classical era. After the Cothon I didn't connect any new lux until Medieval, I don't know if the bug is related to the UNW (the first screenshot though, shows a new luxury I connected after conquering an enemy city, no more lux in Carthage).

[RecursiveVision]

@azum4roll

[azum4roll]

Just revert 3b0c5b2. It must've been already scaling before.

[axatin]

Yes, all types of instant yields scale unless explicitly excluded.

//Exclusion for birth yields and GP expense and policy unlocks (as we do it up above to avoid % growth and religion bonuses from being scaled).
if (bEraScale && iType != INSTANT_YIELD_TYPE_BIRTH && iType != INSTANT_YIELD_TYPE_GP_USE && iType != INSTANT_YIELD_TYPE_POLICY_UNLOCK && iType != INSTANT_YIELD_TYPE_BORDERS && iType != INSTANT_YIELD_TYPE_REMOVE_HERESY && iType != INSTANT_YIELD_TYPE_VICTORY && iType != INSTANT_YIELD_TYPE_VICTORY_GLOBAL)
{
                iValue *= iEra;
}

[RecursiveVision]

I had made it scale, yes...