LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
279 stars 154 forks source link

city governor working too many laborers #11046

Open ilteroi opened 5 days ago

ilteroi commented 5 days ago

v4.9

image

something is wrong with specialist assignment.

in the screenshot (antium) we have 5 laborers for a total of -10f5p5g. by working the jungles + herbalist bonus they could generate 12f5p5s. food might not be the highest prio because of unhappiness but there are also unused specialist slots.

assignment often is not stable. by changing the focus of the governor from default to something else and back you get a different assignment then what the default governor did over multiple turns. often the laborers are completely gone (eg in ravenna).

assignment also seems to run twice (check citytilescorer log).

AutoSave_0230 AD-1600.zip

whoever messed with this please fix, i'm not touching it any more

RecursiveVision commented 4 days ago

@axatin

axatin commented 3 days ago

The save is not from 4.9, and I can't load it with 4.8 either

ilteroi commented 3 days ago

this is weird:

[103848] CvGame.cpp[10998]: CvGame::Read - Savefile was generated from gamecore version Release-4.9.1 bde9b87dc Dirty

but i just checked, i have infoaddict and removebanluxury mods on top. maybe that could be the problem

axatin commented 3 days ago

The save requires Community Patch version 130 to load, which is not 4.9

ilteroi commented 3 days ago

i don't understand ... what is wrong. anyway i have a feeling the issue is quite easily reproducable

axatin commented 3 days ago

image 4.9 is not Community Patch Version 130, but Community Patch Version 131.

I was able to load it now by manually editing the modinfo, but something is messed up in your mod files

axatin commented 3 days ago

There are no errors in the assignment process as far as I can see, only the valuations could maybe be tweaked.

You have a growth mod of -95%, so 3 food are actually 0.15 food. Your city has -7 unhappiness and your empire is also unhappy, so the AI actively wants to avoid growth. Taking these together, the AI values food at 0.

we have 5 laborers for a total of -10f5p5g. by working the jungles + herbalist bonus they could generate 12f5p5s

No, laborers do not consume more food than worked plots. The correct comparison would be 0.6f5p5s vs. 5p5g

The only thing left is that the AI values 1 gold higher than 1 science, and that's because you have 7 Poverty in the city but only 2 Illiteracy. I'll try to tweak that a bit, but I'm very hesitant to make any large changes as those might break a lot of other things again.

ilteroi commented 3 days ago

thanks for the analysis and yes, you're right about the food. so it's more a question of science vs gold. i thought science has a higher value but yeah, it's debateable.

but there are other issues as well:

azum4roll commented 1 day ago

I think yield values shouldn't depend on unhappiness that much, unless the city/empire is already unhappy AND changing the assignment reduces the unhappiness.