No AI code to handle Complete Kills settlers

[RecursiveVision]

@ilteroi If an AI has a Settler and no cities with the Complete Kills game option enabled, they currently:

• Wander randomly in search of a valid plot to settle, unless they happen to be on one already, due to CvHomelandAI::ExecuteFirstTurnSettlerMoves();
• Won't get any military units they might also have alive to escort the Settler to safety;
• Have no code that checks "just found a city in the closest legal position possible that we're able to pathfind to, don't be picky about found value".

I don't know how to create a settle operation, and existing preconditions seem to require an escort as well (an exception would need to be made if the player has zero cities and no military units, only the Settler).

Would you be able to add code for this? It's a necessary prerequisite to implement this proposal: https://forums.civfanatics.com/threads/7-61-complete-the-complete-kills-functionality.689067/

[RecursiveVision]

If this code is removed in CvPlayer::setAlive()

        if (getNumCities() == 0)
            setFoundedFirstCity(false);

Then CvPlayer::isFoundedFirstCity() can be used to differentiate first turn settler moves from Complete Kills settler moves.

[RecursiveVision]

@KungCheops If ilteroi is unable, would you be interested?

[OneFuriousDon]

@RecursiveVision Sorry to budge in but if possible preferably in set min safe distance from oppressor and one extra move from "run for your lives promo".

[RecursiveVision]

That was not in the proposal.

[ilteroi]

not sure i get this - where would this settler spawn? what if there is no reachable spot for settling?

anyway i think it's not too hard. do the change mentioned above. and replace the city number check in IsTestStrategy_FoundCity() with a isFoundedFirstCity() check. should work.

[RecursiveVision]

I implemented the Settler spawn as follows:

• If alive for 10 turns without Settlers or Cities, attempt to spawn a Settler.
• Try to spawn on top of a land combat unit (on land), scoring them with GetMaxDefenseStrength()
• If that fails, try to spawn on top of a civilian unit (on land), scoring them by Production Cost
• If that also fails, the still-living units are either naval or embarked (and I don't know how to spawn a land unit and embark it on the same tile, if that's even doable), plus they might be stuck or something, so pick a random plot on the map that isn't adjacent to or containing enemies, and which a Settler can found a city on.
• If no valid plots, do nothing, but make another attempt next turn.

[RecursiveVision]

@ilteroi Will it work if there's no escort available, or will the settler just be locked in place?

[azum4roll]

Units already automatically spawn embarked (if needed) when using IGE+, given the player has the tech for it.