search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 158 forks source link

more cleanup stuff #11081

Closed azum4roll closed 3 months ago

JohnsterID commented 3 months ago

@azum4roll msvc build warning only, not on clang. https://github.com/LoneGazebo/Community-Patch-DLL/actions/runs/9807219785/job/27080561123

1>CvUnit.cpp(20919): warning C4100: 'fAdditionalTextDelay' : unreferenced formal parameter
azum4roll commented 3 months ago

I know, but that requires a refactor that I couldn't do yet.

There are plenty more unused variables in clang.

JohnsterID commented 3 months ago

Understood. I wasn't even looking at the clang runner with W1 enabled as there are too many unused. The normal non-sdk clang script doesn't have W1 so it is clean.

edit: this was just added https://github.com/LoneGazebo/Community-Patch-DLL/commit/28ae7d524c46404172bf9f2e18711d389d12c918