search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
282 stars 157 forks source link

cppcheck #11085

Closed JohnsterID closed 3 weeks ago

JohnsterID commented 3 weeks ago

Builds work.

Also want to highlight other items found as examples, there are a few.

https://github.com/LoneGazebo/Community-Patch-DLL/actions/runs/9816688840

Id: duplicateCondition
CWE: 398
The if condition is the same as the previous if condition

https://github.com/LoneGazebo/Community-Patch-DLL/blob/13683f4c9beb1980e4179d44a3690a6426c5e7f0/CvGameCoreDLL_Expansion2/CvDealAI.cpp#L6862-L6876 https://github.com/LoneGazebo/Community-Patch-DLL/blob/13683f4c9beb1980e4179d44a3690a6426c5e7f0/CvGameCoreDLL_Expansion2/CvDiplomacyAI.cpp#L7031-L7053