search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
282 stars 157 forks source link

Unused column bug: HappinessToScience #11089

Open Hokath opened 3 weeks ago

Hokath commented 3 weeks ago

I haven't looked into the cpp yet but I just tried out this column with a value of 50 and it is giving me 6 million science per turn. It attributes this to "traits" image

Hokath commented 3 weeks ago

https://github.com/LoneGazebo/Community-Patch-DLL/blob/e842ca159f64d143b1d8b3c1f7982b5cd37186a7/CvGameCoreDLL_Expansion2/CvPlayer.cpp#L34837

Seems like it takes the value but then multiplies it not into a happiness number, but a science number?!

axatin commented 2 weeks ago

The name is misleading. It's a BNW column, for the Rationalism policy: +10% Science while the empire is Happy

azum4roll commented 2 weeks ago

It's still bugged, since the current implementation tries to square your science per turn.

Hokath commented 2 weeks ago

Aha yes I stumbled upon the BNW text somewhere in the mean time.

So does this mean it is bugged in base CP?

azum4roll commented 2 weeks ago

Wait no, it looks correct and I must've misread somehow.

The only wrong thing is attributing it to trait only for VP, when no trait gives this ability.

It may have also be multiplied by 100.