LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 157 forks source link

God of War not Triggering on Barbarian Kill #11169

Closed coinich closed 1 month ago

coinich commented 1 month ago

1. Mod Version (X.Y.Z). Current Version: 4.14.1

2. DirectX Version

3. List of Other Mods

More Unique Components for VP v88 azum4roll's Unit Supply for VP Squads DISABLED

4. Describe the Issue

Killing barbarians does not trigger God of War pantheon. Did not notice any change for conquering cities or killing AI Civ units either.


5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)

Alexander_0178 BC-1720.zip Only one save, but there's a barbarian near Persepolis with a Scout nearby in range to kill it

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

Logs.zip

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH)

8. Steps to reproduce the Issue (Optional)

Kill a barbarian unit. Possibly kill any unit/city?

9. Screenshots of the Issue (Optional) 20240721180713_1 20240721180729_1 20240721180732_1 20240721180743_1 20240721180831_1 20240721180846_1

Hokath commented 1 month ago

Tested God of War with latest version and works for me. Will look at save

coinich commented 1 month ago

Weird. Attaching zips of my mods. Ofc the 4UC mod is 28MB not 25MB so I can't attach directly.

https://drive.proton.me/urls/DSN8AS0KMC#jpDRTchk2OqR

Hokath commented 1 month ago

Opened save -- no yield Spawned new barbarian near Hoplites to the North East -- no yield IGE -- Founded Religion Spawned new barbarian near Hoplites to the North East -- yield again

Hokath commented 1 month ago

so something wonky going on with the Belief backend

azum4roll commented 1 month ago

What's your primary religion?

coinich commented 1 month ago

Err, mine? I mean, I hadn't founded one yet.

Hokath commented 1 month ago

Is that a thing? If you don't have your pantheon in the majority of cities you lose God of War?

coinich commented 1 month ago

I kinda hope not - nobody takes God of War to go hippie peace mode. Capturing even one capital at that point threatens to turn off your pantheon unless/until you get more cities running.

azum4roll commented 1 month ago

It's a "global" belief, so it only works if and only if the belief belongs to your primary religion.

But shouldn't a captured city automatically gain the pantheon before you found?

Hokath commented 1 month ago

Yeah I would have thought so but in this save file at least the conquered cities have no followers

coinich commented 1 month ago

Hmm, I can try checking my past autosaves to see the exact order of things. I believe I conquered Persia before I founded my pantheon - not sure if they had founded one yet. India already had theirs of course.

On Mon, Jul 22, 2024, 21:29 Tom @.***> wrote:

Yeah I would have thought so but in this save file at least the conquered cities have no followers

— Reply to this email directly, view it on GitHub https://github.com/LoneGazebo/Community-Patch-DLL/issues/11169#issuecomment-2244081273, or unsubscribe https://github.com/notifications/unsubscribe-auth/APTLXUGIBDETRCSOU5O2QA3ZNWWZFAVCNFSM6AAAAABLHGSR3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBUGA4DCMRXGM . You are receiving this because you authored the thread.Message ID: @.***>

coinich commented 1 month ago

Unless conquered cities are supposed to take my pantheon... cant remember now.

On Mon, Jul 22, 2024, 21:44 Nick La Pietra @.***> wrote:

Hmm, I can try checking my past autosaves to see the exact order of things. I believe I conquered Persia before I founded my pantheon - not sure if they had founded one yet. India already had theirs of course.

On Mon, Jul 22, 2024, 21:29 Tom @.***> wrote:

Yeah I would have thought so but in this save file at least the conquered cities have no followers

— Reply to this email directly, view it on GitHub https://github.com/LoneGazebo/Community-Patch-DLL/issues/11169#issuecomment-2244081273, or unsubscribe https://github.com/notifications/unsubscribe-auth/APTLXUGIBDETRCSOU5O2QA3ZNWWZFAVCNFSM6AAAAABLHGSR3WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBUGA4DCMRXGM . You are receiving this because you authored the thread.Message ID: @.***>

azum4roll commented 1 month ago

There's actually no reason for Faith on kill to not be local. Maybe we should just change it to local?

coinich commented 1 month ago

Is that a change thats savegame compatible? Do I just need to go back 30-50 turns of autosave and reevaluate how I do things?

axatin commented 1 month ago

Maybe we should just change it to local?

What exactly does that mean?

azum4roll commented 1 month ago

Maybe we should just change it to local?

What exactly does that mean?

Not requiring the belief to be part of the primary religion, instead only the majority religion of the origin city of the unit.

axatin commented 1 month ago

Maybe we should just change it to local?

What exactly does that mean?

Not requiring the belief to be part of the primary religion, instead only the majority religion of the origin city of the unit.

Could be done, but that's something to be discussed in congress. I'd say it's intentional that the bonuses are not given completely unconditionally.