LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 158 forks source link

Feature Request: Make Terrain and Feature movement costs additive #11286

Open RecursiveVision opened 5 days ago

RecursiveVision commented 5 days ago

I've just made some adjustments to the Trailblazer promotion abilities.

IgnoreTerrainCost (in specific terrain) column is now labeled IgnoreTerrainCostIn. It ignores all terrain costs (except rivers, which are included only if a disabled define is enabled) when the destination tile contains the specific terrain or feature.

IgnoreTerrainCostFrom is now a new column in the UnitPromotions_Terrains and UnitPromotions_Features tables. Instead of the above, it only ignores the added cost from the specific terrain or feature.

However, this is currently only applicable to Hills and Mountains, as if a tile contains a feature, the feature's movement cost overrides the tile's base terrain cost. Hills and Mountains are exceptions which add +1 to the movement cost after this.

I don't see why we should have it that way. If we make them additive, that allows for anyone adding say, a new desert or snow feature, to have a 3-movement tile instead of a 2-movement tile, and also makes the new IgnoreTerrainCostFrom column more useful.

Low priority, but maybe someone will be interested eventually.

Tekamthi commented 21 hours ago

i would like a little more control in these tables -- i haven't used them since the recent updates, so consider that things may have changed, but based on extensive use up til VP 4.x there are some inconsistencies etc.

the new 'ignore' columns may provide an alternate method to achieve this, but in the past I had hoped that halfMove and doubleMove could stack -- for example it may be desirable to have a promo with double move in desert, and simultaneously half move in flood plain, so that the unit is faster in desert but same speed in flood plain (otherwise doube in desert used to result in 0.5 moves along flood plain where a flat 1 is desired in all desert). The functionality, if its still the same, is inconsistent with other columns in this table, some of which CAN stack (extraMove stacks with double or half, but double and half don't stack together...)

Also, the extraMove column would be more useful as an integer rather than a boolean, ie if i set extraMove = 3, then that plot costs that promo base moves + 3 -- afaik currently its just a boolean on/off to add base moves + 1 or not.

azum4roll commented 18 hours ago

We should just change everything to MoveCostMod and MoveCostMultiplier.