LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
286 stars 158 forks source link

Memory Leak #2689

Closed Radost closed 7 years ago

Radost commented 7 years ago

1. Mod version: 10-19b with hotfix

2. Mod list: https://mega.nz/#!qFciiKha!vTsBluu1WFerHtqSRJNW1-S2FtlxAdWxlzGpoH1Y-jM

3. Error description: During Aztecs turn the game freezes while consuming more and more memory until it crashes. I did have the problem with Aztecs on the previous turn, but it was only taking too long, not freezing.


Supporting information:

  1. Log files: https://mega.nz/#!fN0X1KKJ!cWJ2cGf1OVLRBV5EbH05-VVQ6jYtqbsA2IEj3Ycl1IQ
  2. Save game : https://mega.nz/#!vU8yQBaA!4VbIfUKXjTrCm2eMp6zZxzVaZJISuG1sVzh6dEdxv_w
  3. CvMiniDump.dmp file: https://mega.nz/#!iMEWVBbC!ZtCQpSMwbHjkutUTup07hfniPA1xJJnhfEXWTTUY628
ilteroi commented 7 years ago

cannot load it unfortunately.

but i do have an idea, will add a failsafe.

edit: try this and see if it helps CvGameCore_Expansion2.zip

LoneGazebo commented 7 years ago

Might've been the beliefclasses bug I fixed too.

Radost commented 7 years ago

@ilteroi The file you've posted indeed solved the crash, but it doesn't have a fix for #2677

LoneGazebo commented 7 years ago

We'll sync up our hotfixes later @Radost .

bompus commented 7 years ago

Same issue here. A couple of very slow end of turns, mem and cpu spike, unresponsive eventually.

ilteroi commented 7 years ago

savegame? maybe yours will work for me ...

bompus commented 7 years ago

@ilteroi I didn't get a save on the previous comment, but it happened again. Savegame on turn 300 https://www.dropbox.com/s/zwfsd21g1yvdlam/AutoSave_0300%20AD-2020.Civ5Save?dl=1.

It's either this turn or the next that required killing via task manager. Mem usage kept climbing steadily, I killed it once it got > 3GB. CPU spiked during the time as well, Civ5 unresponsive. Every time it happens, I get one really slow turn during AI moves, but it seems to recover. The following turn after this slowness is usually the fatal one, so it seems like something builds up.

TechpriestEnginseer commented 7 years ago

Yeah I have this same issue as well. I can't explain why, but the AIs seem to be definitely slow the more vassals there are (AIs perhaps trying to declare war, but being unable to do since it is a vassal state...)

image I was interested on why I started the game from turn 200 and it ended at turn 203 an hour ago when I realized it memory leaked toward that amount.

thunderbird14 commented 7 years ago

Had the same symptoms and tested the dll zipped above. It appears to be working (no more CTD's afterwards)

LoneGazebo commented 7 years ago

AI vassals can't even try to DOW, so it was probably that memory leak. It'll all get ironed out shortly.

Radost commented 7 years ago

He meant DoW'ing someone's else vassals probably.

LoneGazebo commented 7 years ago

That's also forbidden.

TechpriestEnginseer commented 7 years ago

but yeah ilteroi's hotfix fixed it.