LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
293 stars 160 forks source link

Citizen management flawed #4007

Closed vide0gamer closed 6 years ago

vide0gamer commented 6 years ago

1. Mod version (i.e Date - 4/23): 2/27

2. Mod list (if using Vox Populi only, leave blank):

3. Error description: I've noticed that often if I leave citizen management to default, some get assigned to clearly inferior (to me) tiles.

4. Steps to reproduce (optional):


Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

  1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. Make sure you have enabled logging before experiencing an error! Go here to find out how: http://forums.civfanatics.com/showthread.php?t=487482):

Logs.zip

  1. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves): William_0015 BC-3400.zip

  2. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

  3. Screenshots (optional): civ5citman The hill is being used instead of the forested spices, which seems like a no brainer to me as far as this early in the game goes.

LoneGazebo commented 6 years ago

Cities value production a bit more when small to get early infrastructure up. You aren't in debt, so the gold doesn't matter as much, and your growth rate (6 turns) is acceptable to the AI.

G

vide0gamer commented 6 years ago

I guess I just look at it as getting 4 yield compared to 2. I mean, if I work the spice, i'll hit growth in 4 turns instead of 6. If I decide to work the hill with the new citizen, that means over 6 turns, i've traded 2 hammers for 12 food and 6 gold. Is production really worth that much? Also, if I switch to farming as my production, it stays the same, even though working the spice causes growth much faster than working the hill; this is probably a fringe case, as most of the time you would be under food focus anyway.

vide0gamer commented 6 years ago

Better example, later in the same game: civ5citman2 William_0043 BC-2280.zip Why use the crab space instead of the atoll space?

deadstarre commented 6 years ago

both of these pictures look really bad. its a common theme that whenever Gov is making the wrong choice, its because he values some yield much more than a tile which has a bunch more of -other- yields. in the first case, he wants an extra hammer at a terrible exchange. in the 2nd pic, he wants the gold at a god awful exchange. cant he be taught as a general rule the tile with the most yields is the best one to work? because in most cases, thats true and then you dont end up with these.

LoneGazebo commented 6 years ago

I think it is just overemphasizing deficient yields. Going to keep tuning.

LoneGazebo commented 6 years ago

Mm, I also see what is causing perxterrain/feature yields to not be prioritized, I'm missing a +1 value.

G

ilteroi commented 6 years ago

in case this isn't fixed yet:

image

city is stuck at 1 pop ... why not work the jungle instead of the hill?

also, the tooltip says 17.2/15 food ... but the city is not growing.

LoneGazebo commented 6 years ago

I've been working on this.

deadstarre commented 6 years ago

instant bonuses can put the city over the bucket, but if the city is stagnant or starving the pop won't go up, it has to be a positive number to grow. occasionally annoying but i figured it had to be that way

LoneGazebo commented 6 years ago

@deadstarre yep

vide0gamer commented 6 years ago

Still seems to be some problems with this. civ5citman3

Pedro II_0064 BC-1440.zip Why forest instead of lake?

LoneGazebo commented 6 years ago

Herbalist bonus.

vide0gamer commented 6 years ago

That's still a 1/2 food instead of 1 food. Lake is strictly better in this case.

LoneGazebo commented 6 years ago

You've got four forests being worked in total, so the game is getting you a +1f from the herbalist. They're worth the same in that case.

vide0gamer commented 6 years ago

...i'm only working 3 forests.

LoneGazebo commented 6 years ago

that plantation isn't on a forest? I can't really tell, looks like one to me.

vide0gamer commented 6 years ago

Plantation removes forest.

On Thu, Mar 15, 2018, 4:00 PM LoneGazebo notifications@github.com wrote:

that plantation isn't on a forest? I can't really tell, looks like one to me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/LoneGazebo/Community-Patch-DLL/issues/4007#issuecomment-373504231, or mute the thread https://github.com/notifications/unsubscribe-auth/AbBJ7WS-MuoeMt7DyxgOaacejNgxGvI0ks5tesg-gaJpZM4SY6SY .

LoneGazebo commented 6 years ago

definitely, but on my phone it looked like it was still a forest. I'll look at the code.

tu-79 commented 6 years ago

I've seen citizen manager ignoring lake tiles quite often, when they were the best option.

@LoneGazebo @ilteroi Could you explain (or point to code) how does citizen manager valuate tiles? How does the manager know that it needs to work on 2 forest with the herbalist, or 3 desert tiles with the caravansery?

LoneGazebo commented 6 years ago

Yes it knows.

tu-79 commented 6 years ago

That was not my question :) I'm more interested in knowing which approach uses the algorithm. Incremental? Combinations? And how values are assigned to set priorities. I guess it is a big piece of code, but I'm willing to take a look. Maybe another pair of eyes? =)