LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 158 forks source link

Staging a Coup in a CS the player is at war with does not ally the player #5079

Closed UndeadDevel closed 5 years ago

UndeadDevel commented 5 years ago

1. Mod version (i.e Date - 4/23): 11-30-18

2. Mod list (if using Vox Populi only, leave blank):

VP (EUI) City-States Leader for VP (v8) List Enhancements for VP (v4.2) Trade Opportunities for VP (v8.1) Reforestation (v8) (slightly modified by me) Civ-linked GG/GA (v11) Enhanced Naval Warfare for VP (v1.6) Enlightenment Era (VP) (v1.2) Faster Aircraft Animations (v3) Capture Great People (I neutered this one because of compatibility issues) Espionage Mapping (v7) (modified by me) Religious Settlers (v1) Improved Air Recon (v1) Missiles No Supply (v1) More Unique Components for VP (v38) Promotions Flags EUI (v1.1) (slightly modified by me) Subs Ignore Borders (v3) Subs Immune Under Ice (v2) Destination (v4) Filters in Trade Route Overview (VP) (v1.3) (slightly modified by me) Improved City View (VP EUI) (v11.0) Promotion Tree (v17) Upgrade Tree (v9) VP Promo Icons (v1.9)

3. Error description: See title and screenshot. Siam was the ally of Tyre, which is why Tyre was at war with me before the Coup (Siam declared on me because of their DP with Denmark, which triggered when I declared on Denmark because of a trade deal with Sweden and a promise to Morocco); I infiltrated the CS, staged a Coup successfully and the screenshot shows the result: Denmark is now the ally for some reason, Tyre is still at war with me (I am at war with Denmark still, so that makes sense, I guess) and I can't peace out with Tyre in the CS UI.

I don't know what the intended behavior is here, but as the screenshot shows the message I get is that the Coup overthrew the Siamese supporters in favor of a group that is in alliance with me, which strongly suggests that it should be me who is allied now, not Denmark.

So either it's a bug with Coups or a text bug. I waited until the next turn but nothing changed.

4. Steps to reproduce (optional):

  1. DOW on civ that has a CS ally
  2. Infiltrate that CS ally with spies
  3. Conduct successful Coup (probably some other civ needs to have some influence with the CS)
  4. Observe that civ who conducted the Coup did not become the new ally

Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

  1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. Make sure you have enabled logging before experiencing an error! Go here to find out how: http://forums.civfanatics.com/showthread.php?t=487482):

  2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves):

  3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

  4. Screenshots (optional): coup

themagicalyang commented 5 years ago

I think you need to "Make Peace" first?

UndeadDevel commented 5 years ago

I can't make peace with a CS I'm at war with; plus I explicitly wrote

I can't peace out with Tyre in the CS UI.

Either the Coup should end my war with the CS when it succeeds or the message shouldn't say that the Coup "put a group in office that are in alliance with me"; in the latter case a Coup on a CS the player is at war with probably shouldn't be possible to begin with.

I would much prefer Coups to be possible in such circumstances and for them to end the war with the CS, however; they are already much harder to carry out when at war with the CS (I had only a 30% success chance despite a Special Agent carrying out the Coup and the Coup chance being doubled from the Covert Action policy).