LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 158 forks source link

Building_YieldFromFaithPurchase doesn't work #5148

Closed pineappledan closed 5 years ago

pineappledan commented 5 years ago

_1. Mod version: 01/29

2. Mod list (if using Vox Populi only, leave blank): 4UC mod, which includes a new building which uses the new table

_3. Error description: Purchased a missionary in a city with a building which is supposed to give 15% of faith purchase as science in the city. Nothing happens when a purchase is made: image Note in the before/after pictures, that scientific progress has not changed since the missionary was purchased

LoneGazebo commented 5 years ago

What was the faith cost? It can bottom out if the % is less than zero.

pineappledan commented 5 years ago

200 faith cost at 15% conversion, so it should give 30 science

Here's the code as it currently exists INSERT INTO Building_YieldFromFaithPurchase (BuildingType, YieldType, Yield) VALUES ('BUILDING_ARABIA_MADRASAH', 'YIELD_SCIENCE', 15);

There were no database errors in the logs, at least not relating to the Madrasa

LoneGazebo commented 5 years ago

Hmm....

LoneGazebo commented 5 years ago

Dammit, I see why. mea culpa. Here's a debug DLL for your trouble... CvGameCore_Expansion2.zip

pineappledan commented 5 years ago

Out running errands, but I’ll confirm when I get home. Thanks!

pineappledan commented 5 years ago

The fix works!

Once this is in a new hotfix, then 4UC will be up to date. Thanks G!

LoneGazebo commented 5 years ago

Cool!