LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
290 stars 160 forks source link

Negative science on foreign trade route #5605

Closed legenciv closed 4 years ago

legenciv commented 5 years ago

1. Mod version (i.e Date - 4/23):

8/31

2. Mod list (if using Vox Populi only, leave blank):

34UC

3. Error description:

The science bonus on trade routes for the other civ having a tech that you haven't researched can be negative. See screenshot, under the "YOUR SCIENCE GAIN" part for an example. What should be a +7 science from the trade route becomes 1 due to a -3 science modifier from Venice having one tech I don't have.

20190908062459_1

LoneGazebo commented 5 years ago

Weird, all the checks are for positive integers in the function.

legenciv commented 5 years ago

Maybe Trade Confederacy was doing something here? Both me and Venice went Statecraft, maybe this policy affected it somehow.