Naval Ships passing through Cities

[Murderologist]

1. Mod version (i.e Date - 4/23): 1-11

2. Mod list (if using Vox Populi only, leave blank): Just Vox Populi

3. Error description: Everything functions fine. I however can not move my naval ships through key allied city state cities. In the past I was able too.

4. Steps to reproduce (optional):

---

Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. Make sure you have enabled logging before experiencing an error! Go here to find out how: http://forums.civfanatics.com/showthread.php?t=487482):

2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves):

3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

4. Screenshots (optional):

[ilteroi]

hmm. i don't know what the intended behavior is here. moving military through other players' cities sound like an unintended feature to me ...

[Murderologist]

Quite the contrary if the city is Istanbul and is the only port city with access to the Black Sea it becomes very very key in getting naval units in there or passage Panama City state instead of going all the way around. Again you don’t get to go through the city if you aren’t friendly or allied with the state. It was there before and now it’s not accessible

Sent from my iPhone

On Jan 16, 2020, at 1:51 PM, ilteroi notifications@github.com wrote:

 hmm. i don't know what the intended behavior is here. moving military through other players' cities sound like an unintended feature to me ...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[azum4roll]

It's a thing in BNW. Not sure when this was changed in VP.

[Murderologist]

I thought I had it before in vox populi I could be mistaking but it’s a feature I wish would be added back as it really highlights the benefits of forming alliances with key city states.

Sent from my iPhone

On Jan 16, 2020, at 10:42 PM, azum4roll notifications@github.com wrote:

 It's a thing in BNW. Not sure when this was changed in VP.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[Vyyt02]

This was definitely possible a few versions back. I clearly remember commencing a surprising naval assault through an allied city state.

[Murderologist]

I’d like to see this come back

Sent from my iPhone

On Jan 17, 2020, at 5:22 AM, Vyyt notifications@github.com wrote:

 This was definitely possible a few versions back. I clearly remember commencing a surprising naval assault through an allied city state.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ilteroi]

well there is this piece of code:

        if (!IsCivilianUnit() && plot.isCity() && plot.getOwner() != getOwner())
        {
            return false;
        }

so this doesn't seem like a bug, but intentional. i didn't put it there so i won't touch it.

[Murderologist]

Ok where is it and how do we change it for people who want it reverted?

Sent from my iPhone

On Jan 19, 2020, at 2:56 PM, ilteroi notifications@github.com wrote:

 well there is this piece of code:

  if (!IsCivilianUnit() && plot.isCity() && plot.getOwner() != getOwner())
  {
      return false;
  }

so this doesn't seem like a bug, but intentional. i didn't put it there so i won't touch it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[azum4roll]

It has never been possible in VP since I started playing with the mod (in 2018). Only civilian units can pass through allied CS city tile. Also applied to major civ cities with open borders.

[ryanmusante]

Pass through the center city tile or tiles within the city proximity?

[Murderologist]

How or what do I need to alter to allow naval units to pass

Sent from my iPhone

On Jan 19, 2020, at 9:24 PM, Ryan Musante notifications@github.com wrote:

 Pass through the center city tile or tiles within the city proximity?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[UndeadDevel]

@Murderologist You'd need to change appropriate code in the DLL source and recompile the DLL, so it's not an easy fix (if you knew how to do that you wouldn't be asking what to do, no offense).

It would be better to try to convince people on the forum that this should be officially changed for everyone.

[Murderologist]

Well considering it was in the base game and was removed from this intentionally I don’t see why they shouldn’t put it back. It wasn’t ground breaking at all. It was more strategic. Now it’s completely removed from the game for what? I don’t see the imbalance here with earning positioning or access to bodies of water if you develop the friendship with these city states.

Sent from my iPhone

On Jan 19, 2020, at 10:57 PM, UndeadDevel notifications@github.com wrote:

 @Murderologist You'd need to change appropriate code in the DLL source and recompile the DLL, so it's not an easy fix (if you knew how to do that you wouldn't be asking what to do, no offense).

It would be better to try to convince people on the forum that this should be officially changed for everyone.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[UndeadDevel]

I agree, but this is not the place to discuss that.

[Murderologist]

Ok well I was told to post it here so I did

Sent from my iPhone

On Jan 20, 2020, at 12:31 AM, UndeadDevel notifications@github.com wrote:

 I agree, but this is not the place to discuss that.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[ilteroi]

yeah, if it's a bug this is the right place, but since it's a judgement call you should try and get a consensus about the intended behavior on the forum