search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
291 stars 160 forks source link

6/29 (Feature Request) - Update Combat Tooltip to explicitly note "Mounted Archery" #6849

Closed Stalker012345 closed 3 years ago

Stalker012345 commented 4 years ago

1. Mod version (i.e Date - 6/19): 6/29

2. Mod list (if using Vox Populi only, leave blank):

3. Error description: The spearmen promotion is a 33% bonus against mounted units. However, against skirmishers it notes it as "+33% vs archery units".... which isn't fully correct (no bonus vs archers).

Just to make it crystal clear, can we update the tip to either say "+33% vs mounted archery" or "+33% vs mounted"

4. Steps to reproduce (optional): image

Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

  1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. Make sure you have enabled logging before experiencing an error! Go here to find out how: http://forums.civfanatics.com/showthread.php?t=487482):

  2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves):

  3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

  4. Screenshots (optional):

LoneGazebo commented 4 years ago

the text is auto-generated based on the combat class of the unit, which is technically Archery...

Stalker012345 commented 4 years ago

Its also "technically" mounted :)

If it can't be changed I understand, not all features can be done!

RecursiveVision commented 4 years ago

It would be nice if all this was handled in the DLL instead of in LUA. Maybe I can work on that when I get back.

Mileslewis commented 4 years ago

UPDATE Units SET IsMounted = '1' WHERE CombatClass = 'UNITCOMBAT_ARCHER' AND Moves >= 3 AND EXISTS (SELECT * FROM COMMUNITY WHERE Type='COMMUNITY_CORE_BALANCE_UNITS' AND Value= 1 );

Is what sets them to mounted, perhaps this could do with a check that range=1 as well so that any 3 move archers are not counted?

azum4roll commented 4 years ago

That's weird. The promotions check their range instead of moves.