LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
280 stars 155 forks source link

Request #712

Closed Iamblichos closed 8 years ago

Iamblichos commented 8 years ago

I've created a mod where I can transport land units on melee ships. Unfortunately, under the latest community patch, if the melee ship is killed with a land unit that is cargo, it crashes the game. If this is any help to you, you can take a look at my minidump.

cvminidump

Rename the file from .jpg to .zip

LoneGazebo commented 8 years ago

Minidump won't open, though I'll tell you that adding such functionality directly contradicts a chunk of the core unit code. I doubt it'll ever work unless you write a lua hook to kill all the units on the tile before the cargo vessel is destroyed.

G

Iamblichos commented 8 years ago

Strange. Well it used to work just fine so I'm not sure if you changed up any core unit functionality.

I'm not really sure what it's doing because I went into IGE and deleted the land unit that was cargoed, and that made it crash too.

File opened fine for me in visual studio. If you are interested in taking a look at the dump, I can send it some other way to you.

LoneGazebo commented 8 years ago

"Used to work" meaning when? The file opens in VS, but it stacks out to the disassembly, which is virtually useless.

G

Iamblichos commented 8 years ago

With 10-2 iirc

EDIT: let me go try it with 10-2 to verify.

Iamblichos commented 8 years ago

Yep, just tried with 10-2. Attacked a City state with a Trireme with a Spearman as cargo until the boat was killed. No crash. I bet it was a change done from 10-2 to 10-8.

LoneGazebo commented 8 years ago

Ilteroi fiddled around in that code recently, I think, but I'm not sure. In any case, I'm almost at RC for the next version, so it may have to wait. Send me your mod, please.

G

Iamblichos commented 8 years ago

Very strange findings. I played a 40 turn game earlier which prompted the request. Attacked a city state and lost the trireme that had a cargo. First time I noticed the crash. Replayed the crash turn with IGE editor and even deleted the land unit that was cargo on the trireme. Just by deleting the cargo unit made the game crash.

I then tried 10-8, 10-9, 10-13, large islands, classical era start. Created my units with IGE, performed the same routine, and none of them crashed. So I was stumped. Went back to the other game that was 40 turns in and let a few turns go by and lost that trireme again and it didn't crash. So something else is going on here. Must've been coincidental. If it's okay with you, I'll close this out as it appears there is something else going on here.

Iamblichos commented 8 years ago

Yeah sure I'll send it over. Can you give me your email, please?

LoneGazebo commented 8 years ago

Send it to TheLoneGazebo@gmail.com

LoneGazebo commented 8 years ago

Is this still breaking?

LoneGazebo commented 8 years ago

Going to assume that this is working now, as no reply.