LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
289 stars 160 forks source link

"City-States grow wary" fires twice #7316

Closed Dromin closed 3 years ago

Dromin commented 3 years ago

1. Mod version (i.e Date - 12/1): 12-1

2. Mod list (if using Vox Populi only, leave blank):

3. Error description: When declaring war on a city state, the "City-States grow wary" notification is fired twice, resulting in double the number of wary city states. See screenshot below.

4. Steps to reproduce (optional): Declare war on a city state.


Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

  1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. Make sure you have enabled logging before experiencing an error! Go here to find out how: http://forums.civfanatics.com/showthread.php?t=487482): /
  2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves): /
  3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V): /
  4. Screenshots (optional): image
RecursiveVision commented 3 years ago

This is a mistake in CvTeam::DoDeclareWar causing the function to be called multiple times. I fixed this already. :)