search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 157 forks source link

MOD_GLOBAL_TRULY_FREE_GP #7532

Closed RecursiveVision closed 3 years ago

RecursiveVision commented 3 years ago

Going to continue with my gradual cleanup of unnecessary defines/settings...

@LoneGazebo For this one, would it be fair to count this as a bugfix? There are 225 places in the code where it's used, and it seems unnecessary to me, so a potential cleanup opportunity. But I hesitated to remove it earlier as it does affect balance, bugfix though it may be, and is only enabled in the CBP.

If not, maybe there's a way of optimizing the function calls...

RecursiveVision commented 3 years ago

EDIT: Same thing for GLOBAL_SEPARATE_GP_COUNTERS...this one is even more of a bugfix.

RecursiveVision commented 3 years ago

@LoneGazebo Think you missed the notification? :)

LoneGazebo commented 3 years ago

Yeah, I did. Since this is a balance issue, I think we leave it as-is for CP/CBO flexibility.

RecursiveVision commented 3 years ago

Alright.