LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 157 forks source link

Next Version #7691

Closed LoneGazebo closed 3 years ago

LoneGazebo commented 3 years ago

@RecursiveVision @ilteroi @Mileslewis

Please give a brief write-up of your recent changes (since last version) for changelog. Thanks!

LoneGazebo commented 3 years ago

Also, if I could get some help with issue cleanup, that'd be great.

Also also, who messed with the Tercio icon? It looks weird in-game.

RecursiveVision commented 3 years ago

@pineappledan messed with the Tercio icon. Will write up a changelog shortly :)

ilteroi commented 3 years ago

(edited)

changes:

fixes:

LoneGazebo commented 3 years ago

improve instant yield history, can continue playing forever now

is this the fix I did, or did you also tweak it?

pineappledan commented 3 years ago
LoneGazebo commented 3 years ago

@pineappledan the tercio flag looks...wrong. It's not color-coordinating anymore.

LoneGazebo commented 3 years ago

image

pineappledan commented 3 years ago

Just revert change I guess.

ilteroi commented 3 years ago

Just revert change I guess.

i like that new icon ... but why is it red, that's the question?

ilteroi commented 3 years ago

improve instant yield history, can continue playing forever now

is this the fix I did, or did you also tweak it?

no idea what you did ... but now it's storing only the previous thirty turns.

LoneGazebo commented 3 years ago

@pineappledan i think maybe the DDS is just busted? Try resubmitting the change. No rush.

LoneGazebo commented 3 years ago

no idea what you did ... but now it's storing only the previous thirty turns.

Redid the storage logic so that it isn't a fixed-size array based on maxgameturns. Now it's a dynamic vector.

RecursiveVision commented 3 years ago

My changes:

Voluntary Vassalage
- Fixed excessive AI desire for voluntary vassalage
- Masters who accept a voluntary vassal now go to war with anyone the vassal is currently at war with, preventing troops from being kicked out + AI trained to handle this
- Added option to disable voluntary vassalage (DiploAIOptions.sql)
- Fixed being able to have a Defensive Pact and Voluntary Vassalage in the same trade deal

Opinion Score
- Fixed recent trade, common foe, vassal protection opinion bonuses not being applied
- Vassal protection bonus now nullified if you attack your vassal
- Adjusted penalties for competition with the AI
- Reduced "denounced by our friend" penalty, also applies less often
- Reworked common foe bonus to account for power difference between AI and damaged player; now can go up to +100
- The effect of an AI's opinion score on approach selection is now less extreme; increased consideration of leader personality + prioritization if the AI hates or likes a lot of people

Approach
- Improvements to AI approach selection towards both civs and City-States
- Reduced tendency to gravitate towards neutral
- Fixed erratic shifts in approach while AI is planning war
- Fixed a major bug with AI approach prioritization

Bugfixes
- Fixed militaristic City-States not spawning units
- Another major revision of warmongering calculation, fixed excessive penalties and several bugs, dropped flavor elements
- AI less likely to denounce friends
- Fixed some issues with difficulty-related code
- Fixed missing distance check from third party war bribes

Balance
- Penalty for breaking PTP now scales with era
- Fixed excessive anti-warmonger fervor

Other
- Improvements to DP + coop war logic
- Adjustments to AI strength perception of humans
- Diplo Flavors Rework now fully integrated + VictoryCompetitiveness now a 1-10 scale
- AI no longer considers Grand Strategy before the medieval era (for domination) and renaissance era (otherwise); prior to this it uses its "diplo personality" which is based on flavors
- Added text to show when a Peace Treaty with a player's DP ally is blocking the ability to declare war
- Tweaked war information display
- Significant code cleanup and enum sanitization (still ongoing)
RecursiveVision commented 3 years ago

@LoneGazebo My changelog is rather long so I'll post it in the Diplomacy AI Development thread. You can add whatever you feel are the highlights to your changelog and add a note to check that thread if people want to see the full one. :)

In particular I think people will be happy about the bugfixes and voluntary vassalage change.

RecursiveVision commented 3 years ago

@LoneGazebo @pineappledan Here's the commit which added the Tercio flag changes: https://github.com/LoneGazebo/Community-Patch-DLL/commit/5413bb6bdadea6c499c0c39534d47db3fcdf21b5

I'll help close issues.

GLop4 commented 3 years ago

I suggested this original a while ago : ter

newTercioFlag.zip

LoneGazebo commented 3 years ago

@GLop4 that's nearly identical to the conquistador.

Stalker012345 commented 3 years ago

@GLop4 that's nearly identical to the conquistador.

I like that one better than the other one though. the other one is really thin and hard to see. Also shouldn't we at least poll the main forums to see if people like new artwork before just swapping it in?

RecursiveVision commented 3 years ago

Isn't the Tercio originally a Spanish unit though?

Mileslewis commented 3 years ago

Basically all of the World Congress logic is now completely different but I'll try to make some key bullet points.

Proposal Logic:

Special Sessions (Host and Diplomatic Victory Votes):

Deals:

When the patch goes live I'll make a thread on the forum so people can complain

RecursiveVision commented 3 years ago

I closed about 100 issues that appeared to be resolved.

RecursiveVision commented 3 years ago

@Stalker012345 For all the enemy unit panel stuff I'll do some work on fixing it after the next release.

LoneGazebo commented 3 years ago

@pineappledan I fixed it.

GLop4 commented 3 years ago

ter2 I use it for months and never made a confusion.

Stalker012345 commented 3 years ago
  • Receiving extra votes for Diplomatic Victory is less likely than for host
  • Diplomatic Victory votes can no longer be bought.

hehe probably too early for feedback as these are the changes that are going live, but since I see them. I really don't like they are taking away concrete ways to win a victory conditions (getting diplomats and making deals to secure votes) and trading them for fuzzy ways (other civs may....or may not...vote for you, who knows?).

Now I am all for those deals costing you an arm and a leg, if an AI is willing to make a deal where you could win the game, then it should hurt! But....if I can afford it, then let me do it. I think that is way more sastifying to go "okay I convert my +200 GPT reserve into key DV votes" than "oh....the AI voted for me....wow I won....that's....um, cool".

When the patch goes live I'll make a thread on the forum so people can complain

With respect I think they have a right to on this one. This isn't a bug fix or an update in logic, its a fundamental change to how a victory condition is acquired. That's something that should absolutely be debated by the community before implemented.

Mileslewis commented 3 years ago

The Civs randomly voting for you is something that could happen before, I just tried to explain the reason why it would now happen so that people have more of an idea. I do get that it might still feel random though because I'm not sure there is any way of actually seeing your alignment with other civs.

Tbh I agree on the trading votes that I would like to know what people want and do that. EDIT- Would also need to decide how much they should be worth and when it shouldn't happen.

LoneGazebo commented 3 years ago

Diplo votes should be buyable IMO.

RecursiveVision commented 3 years ago

With respect I think they have a right to on this one. This isn't a bug fix or an update in logic, its a fundamental change to how a victory condition is acquired. That's something that should absolutely be debated by the community before implemented.

I think Milae's comment was intended as self-deprecation, not as an attack. :)

But on your core argument, I'm in agreement there.

Diplo votes should be buyable IMO.

I agree, I don't like the idea of them being removed. But they should be expensive.

Mileslewis commented 3 years ago

Well if you all agree I can try to change it before release?

LoneGazebo commented 3 years ago

@Mileslewis I think it should be.

azum4roll commented 3 years ago
AssignStartingPlots:

- Natural Wonder locations require higher fertility, to properly prevent being put in the middle of nowhere. Side effects might include Krakatoa never being placed, please observe.
- Make sure Natural Wonders can never be 3 tiles around City States (up from 1).

Communitu_79a v2.3.0:

- Tweak shortest path algorithm edge weights so it actually works (no more straight unnatural canals)
- Make sure polar sea connections never dig through land in Terra mode
hamorphis commented 3 years ago

When are you planning to release this new version?

RecursiveVision commented 3 years ago

When are you planning to release this new version?

@LoneGazebo I second this, I'm looking forward to playing a game on the new version myself :)

LoneGazebo commented 3 years ago

hopefully today.

hamorphis commented 3 years ago

Great Work of Programming! Wish I knew C++, but I am only a C# guy :)

hamorphis commented 3 years ago

We should have a new special person in the modern era - Great Developer who could write a Great Piece of Software and place it in a Research Lab giving boost to cyber espionage :)

azum4roll commented 3 years ago

We should have a new special person in the modern era - Great Developer who could write a Great Piece of Software and place it in a Research Lab giving boost to cyber espionage :)

And then it gets stolen by a hacker the very next turn