5/19 - Governor Issues

[Stalker012345]

1. Mod version (i.e Date - 4/14): 5/19

2. Mod list (if using Vox Populi only, leave blank):

3. Error description: I'll start my usual suite of governor examples. For our first ones, the usual settler logic. I was able to adjust this and shave 4 turns off a settler.

4. Steps to reproduce (optional):

---

Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. For instructions, go to the repository's main page, under "To enable logging for bug reports"):

2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves; you can change autosave frequency in the game's Options menu):

3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

4. Screenshots (optional):

[LoneGazebo]

what specifically did you adjust?

[Stalker012345]

moved every worker to either 3p or 1f 2p tiles.

[ilteroi]

well, that is weird. i thought food and hammers are equal when building a settler?

that is how the governor acts in any case ... i did not change that part.

[RecursiveVision]

@ilteroi I think it's 2f = 1p when building a Settler. It should say in the city total Production tooltip.

Also this mechanic is a VP thing not a vanilla thing IIRC, so if the logic doesn't account for that it probably should.

[RecursiveVision]

@ilteroi If you're going to make more fixes I'd suggest pulling from RSI first to avoid merge errors later :)

[ilteroi]

uh, why do we need all those special rules anyhow?

what is this supposed to achieve?

[RecursiveVision]

@ilteroi In this case I think it's balance - allowing low Production but high Food cities to still build Settlers.

Also because 50% of the Food is carried over, players who built farms rather than other improvements (which may be a good idea if you're wanting to build Settlers, since they cost a population) aren't punished as much.

[Stalker012345]

@ilteroi I think it's 2f = 1p when building a Settler. It should say in the city total Production tooltip.

Yeah if the governor doesn't know that, no wonder its been so horrendous at setting itself up for settlers for such a long time!

[ilteroi]

well the next question is whether to enable such auto-optimization depending on the build queue for human players at all. historically the answer has been no.

[ilteroi]

where does this food to production conversion even happen? i can't find it

[LoneGazebo]

CvCity. Find the ‘isfoodproduction’ unit attribute and follow it into cvcity

[ilteroi]

that's what i did ...

[LoneGazebo]

Did you find it?

[azum4roll]

It's 50% growth converted to production. Note that the city can still starve if you don't have enough food.

[Stalker012345]

It's 50% growth converted to production. Note that the city can still starve if you don't have enough food.

I've never seen a settler city starve....and I have literally put every worker on hammer only tiles. As soon as the settler finishes, yes massive starvation, but during the production not a bit.

[LoneGazebo]

It's 50% growth converted to production. Note that the city can still starve if you don't have enough food.

It cannot starve, the city is flagged at zero food use/need during settler production

[azum4roll]

It's 50% growth converted to production. Note that the city can still starve if you don't have enough food.

It cannot starve, the city is flagged at zero food use/need during settler production

Is that new? I could starve before when I set everything to production only.

[LoneGazebo]

Nope

[ilteroi]

nope, did not find it, that's why i asked. but it doesn't matter. AI will treat building a settler like production focus in the future. that is the best compromise i can see.

[LoneGazebo]

int CvCity::GetFoodProductionTimes100(int iExcessFoodTimes100) const

[LoneGazebo]

replacement for original function: int CvCity::GetFoodProduction(int iExcessFood) const

[ilteroi]

wow, that is surprisingly complex