LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
290 stars 160 forks source link

Border growth points do not get added in calculation of next border growth for city (only raw culture does) #8404

Closed maarten99 closed 2 years ago

maarten99 commented 2 years ago

1. Mod version (X.Y.Z, e.g. 1.2.0): 1.2

2. Mod list (if using Vox Populi only, leave blank):

3. Error description: For example when using the Celts pantheon that gives +3 Border growth points, it does not get added to the culture to calculate the remaining turns of the next border growth. Forts are also affected.

4. Steps to reproduce (optional):


Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

  1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. For instructions, go to the repository's main page, under "To enable logging for bug reports"):

  2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves; you can change autosave frequency in the game's Options menu):

  3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

  4. Screenshots (optional): Should say 5 turns remaining: (1 culture + 3 BGP -> 20/4 = 5) This is true for both the Pantheon and forts

Mileslewis commented 2 years ago

You get the correct amount when you end turn though right?

maarten99 commented 2 years ago

Yes the BGP helps grow the border, just the UI isn't showing the right turns until growth

pineappledan commented 2 years ago

This has been a known issue for years. It was less of an issue back then, because BGPs were not as common

Well, the city screen is correct, sort of, in that BGPs are not culture. You'd have to have a separate line item for BGPs. Though it would be nice if BGPs were factored into that turn calculation.

LoneGazebo commented 2 years ago

Pretty sure the code includes BGP for that UI element, but I'll look.