search

LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
285 stars 157 forks source link

Incorrect Culture Per Turn Yield in City Screen #8875

Closed phantommaxwell closed 2 years ago

phantommaxwell commented 2 years ago

1. Mod version, and DirectX version if reporting a graphical issue (X.Y.Z, e.g. 2.2.0, DX 10 & 11): 2.2

2. Mod list (if using Vox Populi only, leave blank): ENW EAW 3/4 UC Really Advanced Setup Even More Resources

3. Error description: The City Screen Culture Per Turn list the incorrect amount. I don't where the 63 number comes from. I have 14 Culture per Turn in this City. Even the Boarder Growth expansion estimate is wrong.

I'm glad to see the progress to the next tile acquisition.

4. Steps to reproduce (optional):

Supporting information: Please note that you can attach .zip files by dragging-and-dropping them. If possible, zip up all supporting data and post that way.

  1. Log files (always attach your Logs folder, located at My Documents/My Games/Sid Meier's Civilization 5. For instructions, go to the repository's main page, under "To enable logging for bug reports"):

  2. Save game (always attach a save that was made a turn before the error; located at My Documents/My Games/Sid Meier's Civilization 5/ModdedSaves; you can change autosave frequency in the game's Options menu):

  3. CvMiniDump.dmp file (attach if experiencing a game crash. Located at Program Files/Steam/steamapps/common/Sid Meier's Civilization V):

  4. Screenshots (optional): 20220513213317_1

nobubblegums commented 2 years ago

I remember spotting a change in CityView when updating Improved City View

local iCulturePerTurn = pCity:GetJONSCulturePerTurn();

was changed to . local iCulturePerTurn = pCity:GetJONSCulturePerTurn() + pCity:GetBaseYieldRate(YIELD_CULTURE_LOCAL);

Guess it was @LoneGazebo's edit, could this be related?

edit: Reverting that seems to work, but I haven't tested much

LoneGazebo commented 2 years ago

Probably need to revert my edit, I was trying to quickly patch in YIELD_CULTURE_LOCAL into the culture panel. I'll tinker with it.

Azhral commented 2 years ago

Can confirm same issue in my game. Biggest issue is hovering over the city bar says the number of turns until border expansion occurs but its using the incorrect value. So it says 2 turns to expand with ~75 culture per turn showing in the city screen, but the details show its actually only generating ~15 culture per turn and as such takes much longer to actually pop borders.