Highland map is generated without ruins or luxuries

[Der-Zorn-Gottes]

1. Mod Version (X.Y.Z). Current Version: 2.7.3 Community Patch v 110 Vox Pomuli v 15 EU compabilty v 1 Promotion icons v 6 Promotion tree v 22

2. DirectX Version

3. List of Other Mods

None

4. Describe the Issue

The map highlands is generated without luxuries and ancient ruins, Did not play long enoufg to confirm on strategic resources. Checked continent map, seemd fine.

---

5. Save Game From 1 Turn Before (ALWAYS ATTACH THIS IF POSSIBLE)

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH)

8. Steps to reproduce the Issue (Optional)

9. Screenshots of the Issue (Optional)

[nobubblegums]

@azum4roll I'm just guessing here, but does Highland (and probably some others) don't use VPs AssignStartPlots, hence having this issue with resources? If so we can disable such maps in VP's maplist, preventing them from getting used in the first place, I imagine fixing all wouldn't be feasible

[azum4roll]

Fixing all is feasible, but I need a map list and someone to add them to the VP modinfo file after I fix them all.

Also I probably won't test each of them extensively like I do for standard maps.

[RecursiveVision]

@azum4roll I can add them to VP modinfo.

As for a list, I'd start here: https://github.com/LoneGazebo/Community-Patch-DLL/issues/8663

[nobubblegums]

Oh cool. I added PangaeaPlus and ContinentsPlus for the next version, and we have a Terra script (from More Luxuries iirc), I'm not sure if it overwrites the game's Terra tho. Anyway, I'd say these three (esp. PangaeaPlus) would get the most use out of that list. People have been complaining about CS placement on "Plus" maps, maybe that's an area for improvement. Leaving them aside, if you can think of any improvements&VP optimizations to the base Pangaea map, people would love that, think it's the second most popular map after communitu.

ps: I think you can disregard Amazon.lua (from Explorer's Map Pack) from that list, it seemed like a worse version of AmazonXP (from G&K iirc) to me. Only map I didn't readd from EMP

[azum4roll]

Is it ok if I just remove the whole part of "assigning all CS outside of regions" in plus maps?

That's essentially what the plusplus maps are doing I guess.

[Der-Zorn-Gottes]

Just to make it clear: I have played highlands without any issues for years. It's only been since the last patch that things are messed up.

[RecursiveVision]

@azum4roll If that's the whole point of the map, removing it doesn't make much sense. May as well not include the map.

[nobubblegums]

Yeah, no need to remove it if it's identical to standard Pangaea in other ways.

[azum4roll]

It's commented to be "better than standard maps" and the CS thing is a downside. I think these maps make better islands?

[RecursiveVision]

Can change the description if it's wrong.

[jayeye2011]

I noticed that @azum4foll has added VP compatible versions of the vanilla mapscripts to the main repository. I wanted to tryout the Fontier.lua but the VP version has the same name as the vanilla version mapscript so its not possible to determine which to choose. I would recommend that you go back and edit the GetMapScriptInfo() function so that the Name = "" line includes "for VP" for all VP updated mapscripts in the new build version so that the user can differentiate VP compatible versions from the vanilla versions in the map list during game setup.

[azum4roll]

There should be a way to replace the original scripts in modinfo?

[jayeye2011]

Because I play single player using a MP_MODPACK (due to faster load time) the VP installation map folders included maps are not visible in-game unless I manually copy the VP maps script I want to use to my user documents\My Games\Sid Meier's Civilization 5\maps folder. As a result, both the vanilla map and the VP map are listed in the game map selection, so the only way to differentiate them is by the name that is used in the GetMapScriptInfo() function in the lua file.