LoneGazebo / Community-Patch-DLL

Community Patch for Civilization V - Brave New World
Other
289 stars 160 forks source link

Founding in non-capital city breaks automatic faith purchase #9852

Closed TadhgEomonn closed 1 year ago

TadhgEomonn commented 1 year ago

1. Mod Version (X.Y.Z). Current Version: 3.5.1 using current version

2. DirectX Version DX 10 & 11

3. List of Other Mods

MODS (sorry, many mods) (1) Community Patch (2) Vox Populi (3a) VP - EUI Compatibility Files (4a) Promotion Icons for VP (4b) UI - Promotion Tree for VP (7) VP Community Events (v 7) (7c) Leugi's Israel for VP (v17) (8) Events and Decisions (CBO) (v 14) (9d) Reforestation for VP (v5) (over) More Unique Components for VP (v 84) (overhaul) Enhanced Naval Warfare for Vox Populi (v 2.1 vp2.5) (overhaul) More Wonders for VP (v0.17.2) (overhaul) Unique City States for VP (v11.3) (primary) - GH's Scotland - Robert I Bruce for VP (v.16) (text) Promotion Overhaul for VP (v35) (ui) City-States Leaders for VP (v16) (ui) List Enhancements for VP (6.1) (ui) Meaningful Colours (v 12) (ui) Overlay Compendium (v 3) (ui) Small Resource Icons for MW (v 5) (ui) Trade Opportunities for VP (v12) (ui) Wonder Planner For VP (v12) (visual) Unit Scaling and Formation for VP (v 10) (visual) USnF for VP Custom Civilizations (v 6) Auto-production Cities (v 1) Better City Defenses for VP (v 6) Better Lakes for Vox Populi (v 2.5) Buildings - City Automaton Workers (v 1) Calypso's Colored Religious Icons (Basic) (v 4) Capture Great People for VP (v 3) City Limits (v 7) Civ IV Traits VP (v 9) Civic And Reform (v 19) Colonialist Legacies' Canadian Dominion for VP (V25) Commander Influence Borders for VP Convert Caravans and Cargo Ships (v 1.1) Even More Resources for Vox Populi (v 10) Few More Buildings (vp 3.0) Global - Faith Purchases in Puppets (v 1) Greatest Cities (v 11) Improved City View (v 18) InfoAddict (v 22) InGame Editor+ (v 45) Milae's Hotkeys (WASD) (With EUI) (v 4) Monopoly Buildings for Vox Populi (v 3.5) National Parks (v 4) National Wonder Collection (v 3) New Beliefs Mods (v16) Perfidious Recon Units (v 1.1) Pontoon Bridges for VP (v 2) ProjectAlerts (v 1) Provincial Palace (v 3) Quick Turns (v 10) Religion - Permanent Pantheons (v 1) Reworked Top Panel (v 4) Sixth Policy VP (v 4) Ski Resort and Marina Building for VP (v 1) Squads for VP (v 1) Subs Ignore Borders for ENW (v 1) UI - City Production (v 15) UI - City Religions (v 4) UI - Destination (v 4) UI - Diary (v 21) UI - Enhanced Demographics (v 6) UI - Military Log (v 2) UI - Natural Wonders Icons Remain Visible (v 1) Upgrade All Units Button In Military Overview (v 1) Vox Populi's Bare Necessities (v 9) Wonder Race (v 7)

4. Describe the Issue Founding a religion in a non-capital city breaks faith purchase options so that only (1) Remind me later and (2) Save for Great Prophet are listed.

Civ5Screen0000 (Founded in non-capital city)

After converting the capital to the new religion the automatic faith options appear as expected.

Civ5Screen0001 (Founded in non-capital city and capital is converted)


_5. Save Game From 1 Turn Before

I neglected to save 1 turn before issue because I read that the issue had already been solved.

6. Logs (ALWAYS ATTACH THESE IF POSSIBLE)

Logs.zip

7. CvMiniDump.dmp File (ATTACH IF REPORTING A GAME CRASH) Not a crash.

8. Steps to reproduce the Issue (Optional) skip

9. Screenshots of the Issue (Optional) see above, in description

TechpriestEnginseer commented 1 year ago

WTF? DID IT BREAK AGAIN? I THOUGHT I FIXED IT

TechpriestEnginseer commented 1 year ago

Ok, it is now fixed for the next version. Thank you!! https://github.com/LoneGazebo/Community-Patch-DLL/pull/9851

TadhgEomonn commented 1 year ago

Playing version 3.5.2 the same phenomena, so not completely fixed.

Civ5Screen0002

TechpriestEnginseer commented 1 year ago

Playing version 3.5.2 the same phenomena, so not completely fixed.

Civ5Screen0002

if U can repeat it, please post lua.log. You can obtain lua.log from this https://forums.civfanatics.com/threads/how-to-enable-logging.487482/

TadhgEomonn commented 1 year ago

Here is PrtScr from turn before founding: Civ5Screen0003

And this is a PrtScr from the following turn in which religion is founded: Civ5Screen0004

Here is Lua.log, zipped: Lua.zip

Appreciate your stick-to-itiveness. Hope the log helps. Good luck.

TechpriestEnginseer commented 1 year ago

Hmm, interesting! I'm afraid of that other error, but... it shouldn't be related to this issue now. I thank you for your cooperation in reporting it!

ReligionOverview.zip Please download this .zip and extract it to replace your (2) Vox Populi\Core Files\CoreLua\ReligionOverview.lua Then repeat save again. If it works, yay! It's save-game compatible so it'll work with all your future saves.

Backup your original ReligionOverview.lua however!

TadhgEomonn commented 1 year ago

Success!!!

Your ReligionOverview.lua worked. Many thanks, Enginseer, for your efforts in solving this.

TechpriestEnginseer commented 1 year ago

Great!

https://github.com/LoneGazebo/Community-Patch-DLL/pull/9854