search

Lonefy / vscode-JS-CSS-HTML-formatter

JS,CSS,HTML formatter for vscode
48 stars 23 forks source link

the "save" event should not change the document by default.. #104

Open GeraldRyan opened 4 years ago

GeraldRyan commented 4 years ago

That's just my opinion but I am pretty new to coding and advanced IDE features. I love learning all the ins and outs and customizing and advanced features, but for saving a document to default split up your CSS reset each into its own line for instance can be scary and confusing to newbies and if they have a project to turn in, can add to stress levels. I got it fixed by changing the internal config, even without having to disable the extension, even though disabling it told me it was the reason. To do this you have to know where to look and then know what to do about it, which takes some understanding. That's just a comment but I think the save event should save the document and nothing else, unless the user sets it up otherwise or downloads an extension that overtly advertises that feature.

maslade commented 4 years ago

+1. This feature caused me a decent amount of lost time. It was triggering on a SCSS file (not JS, CSS, or HTML), so it took me a while to identify this extension as the culprit. I've also never seen formatters that operate on save as a default, so it was jarring to save an existing file and have it completely rewritten. It seems like over-zealous out-of-box behavior.

waldyrious commented 4 years ago

Same here. I actually came to this repo from this comment in the vscode repo, because after turning off the editor.codeActionsOnSave.source.fixAll and editor.formatOnSave settings, I was still getting changes in my code when saving, so I thought it was actually an issue in VSCode itself.