search

Lonefy / vscode-JS-CSS-HTML-formatter

JS,CSS,HTML formatter for vscode
48 stars 23 forks source link

"onSave" formats but doesn't save the file #12

Open richardbourne-ct opened 8 years ago

richardbourne-ct commented 8 years ago

File is being formatted correctly but the file is still in an unsaved state - I would expect the process to be done in one.

Arrow7000 commented 8 years ago

I had the same problem for ages. I could not work out why every time I save the file is still in an unsaved state. This explains it.

Meanwhile I had to set onSave to false, because I had to save the file twice every single time.

Lonefy commented 8 years ago

'Save twice' is a bad experience, and I find that it will change 'save-state' endlessly sometimes.

Arrow7000 commented 8 years ago

Exactly... that's the problem.

DsrMedia commented 8 years ago

I have the same issue, as described from Arrow7000 with latest release of vscode and your plugin. I deinstalled the plugin now saving is working again as expected. It would be nice if you can fix this issue.

WhatFreshHellIsThis commented 8 years ago

There may be another issue related to this, I've seen one file be intermittently overwritten with the contents of another open file when I save and it does the auto-format before saving for both files, can't pin it down to the extension or the editor itself but I've disabled format on save and will monitor it.

thekalinga commented 7 years ago

I have mistakenly reported the same issue here to vscode.

https://github.com/Microsoft/vscode/issues/16510

thekalinga commented 7 years ago

After disabling this plugin, I no longer see the issue with autosave settings

Lonefy commented 7 years ago

@thekalinga what's the version of your vscode and extension？

thekalinga commented 7 years ago

vscode:

Version 1.8.0-insider Commit 7499a9f3c565f4fbe5205e30c8664e5a5a11ae94 Date 2016-12-06T16:09:29.346Z Shell 1.4.6 Renderer 53.0.2785.143 Node 6.5.0

Extension version

0.2.2